feat(aws-cdk): add support for user provided repository name to DockerImageAsset #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geAsset. This change makes it easier to use (reference) Docker Images created and deployed by CDK from EKS (Kubernetes) YAML resource files.
rix0rrr
reviewed
Mar 18, 2019
…ctions (aws#2020) Additional input Artifacts are needed when using the `parameterOverrides` property of the Action (any Artifact used in that map needs to be added to the input Artifacts of the Action, otherwise the Pipeline will fail at runtime). Also did some cleanup in the Action superclass while I was in the area. Fixes aws#1247
Update class name in docs, remove outdated paragraph.
Add constructs for email receiving.
Without this fix, the `Not` condition would render as (notice that `variable`, `comparisonOperator` and `value` are not capitalized):
```
{ Not:
VariableComparison { variable: '$.a', comparisonOperator: 0, value: 'b' } }
```
Update the build tools to take an argument to pack only a subset of language targets.
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes aws#778.
Because of accepted Tokenized values, cfn2ts previously translated a
string and string array into:
interface Props {
someString: string;
stringArray: Array<string | Token> | Token;
}
The latter was not intended. We now emit:
interface Props {
someString: string;
stringArray: string[];
}
Since the Token will be typed as `Object` in Java, this change now makes
it impossible to mistakenly pass any old java Object. A typical case
would be pass a `Subnet` where a `string subnetId` was expected, failing
in a nonobvious way.
Fixes aws#2030.
The role input parameters are currently Roles but should be IRoles. Required adding the grant methods to the `IRole` definition, which weren't there before. Fixes aws#1925.
Also in this commit: - Bugfix to the update script to compile, so create-new-libraries is actually run on the new spec. - Add 'npm run set-refkind' to make it easier to set refkinds for new resources.
…tion") (aws#2047) The method `toCloudFormation` is not supposed to be directly called by users. Mark it as `@internal` and rename to `_toCloudFormation`. Fixes aws#2044 Related aws#2016 BREAKING CHANGE: “toCloudFormation” is now internal and should not be called directly. Instead use “app.synthesizeStack”
Update `instanceCount` => `desiredCapacity` in ECS README. Fixes aws#1926.
|
Alex, I cannot push updates to this branch, probably because it's based off of your https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork If not, can you please make a branch and update this PR to track your branch instead? |
|
Yes |
alex-berger
requested review from
RomainMuller,
skinny85 and
SoManyHs
as code owners
rix0rrr
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for (optional) user provided repository name to DockerImageAsset. This change makes it easier to use (reference) Docker Images created and deployed by CDK from EKS (Kubernetes) YAML resource files. In contrast to ECS/Fargate Tasks one cannot directly pass dynamically created ECR repository names to Kubernetes Pod resource definitions (YAML files) as these resources are not managed by CloudFormation. This PR allows users to use predefined (well-known) ECR repository names, which can then be refered to from within Kubernetes Pod resource definitions using the
latestimage tag. For example the Docker Image created by:Can then be referenced from a Kubernetes Pod resource definition like this:
Note, this changes do not affect the synthesized CloudFormation template as the repository is passed
into the stack as parameter. Futhermore, there are not unit tests as I was not able to figure out how to
add unit test for
ToolkitInfo. I tested this new feature manually and it worked well, pusing the resutling Docker Image into an ECR repository with the expected repository name.Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.