Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-certificatemanager) update docs #2028

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Conversation

spg
Copy link
Contributor

@spg spg commented Mar 15, 2019

Follow-up to #1985 (comment)


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@spg spg requested a review from a team as a code owner March 15, 2019 23:00
@otterley
Copy link
Contributor

Thanks! While you're at it, can you eliminate this outdated paragraph as well?

DNS validation is possible in ACM, but is not currently available in CloudFormation. A Custom Resource will be developed for this, but is not currently available.

@spg
Copy link
Contributor Author

spg commented Mar 16, 2019

@otterley sure, done in c4bf99d

@spg spg changed the title fix(aws-certificatemanager) update class name in docs fix(aws-certificatemanager) update docs Mar 16, 2019
@rix0rrr rix0rrr merged commit a57c6d5 into aws:master Mar 16, 2019
rix0rrr pushed a commit to alex-berger/aws-cdk that referenced this pull request Mar 19, 2019
Update class name in docs, remove outdated paragraph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants