Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-certificatemanager) export dns-validated-certificate #1985

Merged
merged 4 commits into from
Mar 12, 2019

Conversation

spg
Copy link
Contributor

@spg spg commented Mar 9, 2019

Fixes an issue where the DNSValidatedCertificate class (see #1797) is not importable. Output from typescript compilation:

lib/backend-stack.ts:12:10 - error TS2305: Module '"../../../../../../Users/spgingras/myproject/src/backend/node_modules/@aws-cdk/aws-certificatemanager/lib"' has no exported member 'DNSValidatedCertificate'.

12 import { DNSValidatedCertificate } from '@aws-cdk/aws-certificatemanager';


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@spg spg requested a review from a team as a code owner March 9, 2019 06:06
@spg spg changed the title fix(acm) export dns-validated-certificate fix(aws-certificatemanager) export dns-validated-certificate Mar 9, 2019
@eladb
Copy link
Contributor

eladb commented Mar 11, 2019

Can you please also rename the class to DnsValidatedCertificate to conform with our naming guidelines (and since it hasn't been exported, it's not even a breaking change?)

@spg
Copy link
Contributor Author

spg commented Mar 12, 2019

@eladb Sure, done in e89632f.

Also, I'm not sure what I have broken in the CodeBuild check.

@eladb
Copy link
Contributor

eladb commented Mar 12, 2019

The build issue was related to the .NET build: the access modifier of the validate method should be protected but it was public (committed a fix). This should obvsiouly have been discovered by jsii (aws/jsii#289).

@eladb eladb merged commit aa0042b into aws:master Mar 12, 2019
@spg spg deleted the fix-acm-export-dns-validated-certificate branch March 12, 2019 15:37
@otterley
Copy link
Contributor

Since the name of the class has changed, can you also update the documentation?

@spg spg mentioned this pull request Mar 15, 2019
4 tasks
@spg
Copy link
Contributor Author

spg commented Mar 15, 2019

@otterley sure, done in #2028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants