Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (fix) jsii-pacmak patch not applied during packing #16877

Merged
merged 1 commit into from
Oct 11, 2021
Merged

chore: (fix) jsii-pacmak patch not applied during packing #16877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,18 @@ export PATH=$PWD/node_modules/.bin:$PATH
export NODE_OPTIONS="--max-old-space-size=8192 ${NODE_OPTIONS:-}"
root=$PWD

### HACKS - Remove once jsii-pacmak@>=1.39.0
# Temporary work-around
# The pack on v2 is currently broken due to a bug in jsii-pacmak <= 1.38.0 that packs all modules in
# parallel, regardless of dependencies between the modules. That breaks on building the alpha modules,
# since they rely on aws-cdk-lib, but often end up being packed first. A fix was created in jsii
# (https://github.com/aws/jsii/pull/3045), but to unblock the build earlier, a patch was created to
# apply the fix within the CDK prior to the next jsii release (https://github.com/aws/aws-cdk/pull/16871).
# Unfortunately, our build "transform" step runs a `lerna` command that re-installs jsii-pacmak, removing
# the patch. Calling `yarn install` here again to re-install and re-apply the patch prior to packing.
yarn install --frozen-lockfile
### HACKS - Remove once jsii-pacmak@>=1.39.0

# Get version and changelog file name (these require that .versionrc.json would have been generated)
version=$(node -p "require('./scripts/resolve-version').version")
changelog_file=$(node -p "require('./scripts/resolve-version').changelogFile")
Expand Down