chore: (fix) jsii-pacmak patch not applied during packing #16877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pack on v2 is currently broken due to a bug in jsii-pacmak <= 1.38.0 that packs all modules in parallel, regardless of dependencies between the modules. That breaks on building the alpha modules, since they rely on aws-cdk-lib, but often end up being packed first. A fix was created in jsii (aws/jsii#3045), but to unblock the build earlier, a patch was created to apply the fix within the CDK prior to the next jsii release (#16871). Unfortunately, our build "transform" step runs a `lerna` command that re-installs jsii-pacmak, removing the patch. Calling `yarn install` here again to re-install and re-apply the patch prior to packing.
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
approved these changes
Oct 11, 2021
Which will hopefully happen automatically, so anywhere we put a comment is a bit pointless. I'm watching this very closely and keeping an eye on the latest jsii release. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pack on v2 is currently broken due to a bug in jsii-pacmak <= 1.38.0 that
packs all modules in parallel, regardless of dependencies between the
modules. That breaks on building the alpha modules, since they rely on
aws-cdk-lib, but often end up being packed first. A fix was created in jsii
(aws/jsii#3045), but to unblock the build earlier, a
patch was created to apply the fix within the CDK prior to the next jsii release
(#16871). Unfortunately, our build
"transform" step runs a
lernacommand that re-installs jsii-pacmak, removingthe patch. Calling
yarn installhere again to re-install and re-apply thepatch prior to packing.
Note: This will become obsolete once jsii-pacmak 1.39.0 is released
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license