feat(cloudfront-origins): ability to specify minimum origin SSL protocol #11997

robertd · 2020-12-10T18:52:38Z

closes #11994

BREAKING CHANGE: Default minimum origin SSL protocol for HttpOrigin and LoadBalancerOrigin changed from SSLv3 to TLSv1.2.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2020-12-10T18:52:41Z

robertd · 2020-12-10T20:36:54Z

I'm not sure why the build is failing as I cannot see contents of AWS CodeBuild us-east-1 (AutoBuildProject6AEA49D1-qxepHUsryhcu) step.

skinny85 · 2020-12-10T20:54:56Z

@robertd you have the build output posted as a comment on the PR (example: #11997 (comment) ).

robertd · 2020-12-10T21:14:19Z

Thank you @skinny85

I've been getting totally different errors building locally, but targeted package build using ../../../scripts/buildup works just fine. This has been an ongoing issue I've been experiencing building locally... something about dotnet build on Mac.

aws-cdk: Please run 'npm install'!
aws-cdk: ✅ All done!
aws-cdk: Applying project template app for csharp
aws-cdk: /bin/sh: dotnet: command not found
aws-cdk: FAIL test/init.test.js
aws-cdk:   ● v1 tests › verify "future flags" are added to cdk.json
aws-cdk:     Could not add project AwsCdkTestD9Pe7S.csproj to solution AwsCdkTestD9Pe7S.sln. Error code: 127
aws-cdk:       at ChildProcess.<anonymous> (../../../../../../../private/var/folders/qy/4g09xft92tl4920lgkhc111c00265b/T/aws-cdk-testD9PE7s/tmp/add-project.hook.ts:29:16)
aws-cdk:   ● v2 tests › verify "future flags" are added to cdk.json
aws-cdk:     Could not add project AwsCdkTestv6KZel.csproj to solution AwsCdkTestv6KZel.sln. Error code: 127
aws-cdk:       at ChildProcess.<anonymous> (../../../../../../../private/var/folders/qy/4g09xft92tl4920lgkhc111c00265b/T/aws-cdk-testv6kZEL/tmp/add-project.hook.ts:29:16)
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: mockStack: creating CloudFormation changeset...
aws-cdk: CDKToolkit: creating CloudFormation changeset...
aws-cdk: CDKToolkit: creating CloudFormation changeset...
aws-cdk: PASS test/api/bootstrap.test.js (5.493 s)
aws-cdk: PASS test/context-providers/asymmetric-vpcs.test.js (5.9 s)
aws-cdk: PASS test/context-providers/load-balancers.test.js (5.927 s)
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Using default execution policy of 'arn:aws:iam::aws:policy/AdministratorAccess'. Pass '--cloudformation-execution-policies' to customize.
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   123456789012
aws-cdk: Trusted accounts:   123456789012
aws-cdk: Trusted accounts:   (none)
aws-cdk: Trusted accounts:   123456789012
aws-cdk: Execution policies: arn:aws:something
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: PASS test/context-providers/vpcs.test.js (6.681 s)
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:policy
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: Trusted accounts:   (none)
aws-cdk: Execution policies: arn:booh
aws-cdk: PASS test/api/bootstrap2.test.js
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (767fdcc7-88a1-4500-a362-09912cd9ce40)the_account_#
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (b870aca8-32cd-4456-bfac-a254e91ba6ce)the_account_#
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (6696b43c-a717-4631-97b3-860bdf5f0378)the_account_#
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (6276cd86-cae4-48a4-82b5-6e0729ab2545)the_account_#
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (d37c0e59-1c32-4de5-95ce-544c763e082b)the_account_#
aws-cdk: Assuming role 'arn:aws:iam::account:role/role'.
aws-cdk: Resolving default credentials
aws-cdk: Require MFA token for serial ARN arn:aws:iam::account:mfa/user
aws-cdk: Failed to get MFA token Error: test
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/packages/aws-cdk/test/api/sdk-provider.test.ts:3:32
aws-cdk:     at Runtime.requireMock (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-runtime/build/index.js:802:55)
aws-cdk:     at Runtime.requireModuleOrMock (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-runtime/build/index.js:917:21)
aws-cdk:     at Object.<anonymous> (/Users/rdjurasaj/code/robertd/aws-cdk/packages/aws-cdk/test/api/sdk-provider.test.ts:36:13)
aws-cdk:     at Runtime._execModule (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-runtime/build/index.js:1299:24)
aws-cdk:     at Runtime._loadModule (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-runtime/build/index.js:898:12)
aws-cdk:     at Runtime.requireModule (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-runtime/build/index.js:746:10)
aws-cdk:     at jasmine2 (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/index.js:230:13)
aws-cdk:     at runTestInternal (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-runner/build/runTest.js:380:22)
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:93:5)
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withparameters: creating CloudFormation changeset...
aws-cdk: withparameters: creating CloudFormation changeset...
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (b4d842a3-2161-4b97-ba43-fd9df7b6e110)the_account_#
aws-cdk: Using proxy server: http://DOESNTMATTER/
aws-cdk: withparameters: creating CloudFormation changeset...
aws-cdk: Resolving default credentials
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: Unable to determine the default AWS account: ProcessCredentialsProviderFailure: Profile assumable did not include credential process
aws-cdk:     at ProcessCredentials.load (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:103:30)
aws-cdk:     at ProcessCredentials.coalesceRefresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:209:12)
aws-cdk:     at ProcessCredentials.refresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:165:10)
aws-cdk:     at ProcessCredentials.get (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:124:12)
aws-cdk:     at resolveNext (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:128:17)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:129:13
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:127:23
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:216:15
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:75:11) {
aws-cdk:   code: 'ProcessCredentialsProviderFailure',
aws-cdk:   time: 2020-12-10T21:09:28.850Z
aws-cdk: }
aws-cdk: Using proxy server: http://localhost:8080/
aws-cdk: Assuming role 'bla.role.arn'.
aws-cdk: Resolving default credentials
aws-cdk: [AWS s3 undefined 0.002s 0 retries] listBuckets({})
aws-cdk: Call failed: listBuckets(undefined) => Could not assume role in target account (did you bootstrap the environment with the right '--trust's?): Nope!
aws-cdk: [AWS s3 undefined 0s 0 retries] listBuckets({})
aws-cdk: Call failed: listBuckets(undefined) => Could not assume role in target account (did you bootstrap the environment with the right '--trust's?): Nope!
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: Changeset CDK-4587319f-c6f6-4bb5-87ef-f301f6bafc60 created and waiting in review for manual execution (--no-execute)
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: Changeset CDK-d3ef70c5-8fe4-4b34-b394-910ed8a35d8a created and waiting in review for manual execution (--no-execute)
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: Changeset CDK-97de6549-5aeb-4a1c-80a6-9df4794e900a created and waiting in review for manual execution (--no-execute)
aws-cdk: termination-protection: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: withouterrors: creating CloudFormation changeset...
aws-cdk: Assuming role 'bla.role.arn'.
aws-cdk: Resolving default credentials
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (442d9734-3f76-44fa-85e3-eb30533aad38)the_account_#
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (a47c20c3-6687-4a45-bbad-e8e6d7e53e0e)the_account_#
aws-cdk: Using test plugin credentials for account (a47c20c3-6687-4a45-bbad-e8e6d7e53e0e)plugin_account_#
aws-cdk: Assuming role 'arn:aws:iam::12356789012:role/Assumable'.
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (bffcbb0d-74c2-437c-af1e-ca975318d258)the_account_#
aws-cdk: Using test plugin credentials for account (bffcbb0d-74c2-437c-af1e-ca975318d258)plugin_account_#
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Default account ID: (8ef2a414-cf92-4cff-b4ea-b18c393b48c0)the_account_#
aws-cdk: Unable to determine AWS region from environment or AWS configuration (profile: "ecs"), defaulting to 'us-east-1'
aws-cdk: Resolving default credentials
aws-cdk: Unable to determine the default AWS account: ProcessCredentialsProviderFailure: Profile ecs did not include credential process
aws-cdk:     at ProcessCredentials.load (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:103:30)
aws-cdk:     at ProcessCredentials.coalesceRefresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:209:12)
aws-cdk:     at ProcessCredentials.refresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:165:10)
aws-cdk:     at ProcessCredentials.get (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:124:12)
aws-cdk:     at resolveNext (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:128:17)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:129:13
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:127:23
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:216:15
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:75:11) {
aws-cdk:   code: 'ProcessCredentialsProviderFailure',
aws-cdk:   time: 2020-12-10T21:09:29.003Z
aws-cdk: }
aws-cdk: Unable to determine AWS region from environment or AWS configuration (profile: "ecs"), defaulting to 'us-east-1'
aws-cdk: Resolving default credentials
aws-cdk: Unable to determine the default AWS account: ProcessCredentialsProviderFailure: Profile ecs did not include credential process
aws-cdk:     at ProcessCredentials.load (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:103:30)
aws-cdk:     at ProcessCredentials.coalesceRefresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:209:12)
aws-cdk:     at ProcessCredentials.refresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:165:10)
aws-cdk:     at ProcessCredentials.get (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:124:12)
aws-cdk:     at resolveNext (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:128:17)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:129:13
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:127:23
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:216:15
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:75:11) {
aws-cdk:   code: 'ProcessCredentialsProviderFailure',
aws-cdk:   time: 2020-12-10T21:09:29.011Z
aws-cdk: }
aws-cdk: Unable to determine AWS region from environment or AWS configuration (profile: "ecs"), defaulting to 'us-east-1'
aws-cdk: Resolving default credentials
aws-cdk: Unable to determine the default AWS account: ProcessCredentialsProviderFailure: Profile ecs did not include credential process
aws-cdk:     at ProcessCredentials.load (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:103:30)
aws-cdk:     at ProcessCredentials.coalesceRefresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:209:12)
aws-cdk:     at ProcessCredentials.refresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:165:10)
aws-cdk:     at ProcessCredentials.get (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:124:12)
aws-cdk:     at resolveNext (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:128:17)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:129:13
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:127:23
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:216:15
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:75:11) {
aws-cdk:   code: 'ProcessCredentialsProviderFailure',
aws-cdk:   time: 2020-12-10T21:09:29.019Z
aws-cdk: }
aws-cdk: Unable to determine AWS region from environment or AWS configuration (profile: "assumable"), defaulting to 'us-east-1'
aws-cdk: Resolving default credentials
aws-cdk: Unable to determine the default AWS account: ProcessCredentialsProviderFailure: Profile assumable did not include credential process
aws-cdk:     at ProcessCredentials.load (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:103:30)
aws-cdk:     at ProcessCredentials.coalesceRefresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:209:12)
aws-cdk:     at ProcessCredentials.refresh (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/process_credentials.js:165:10)
aws-cdk:     at ProcessCredentials.get (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:124:12)
aws-cdk:     at resolveNext (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:128:17)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials/credential_provider_chain.js:129:13
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:127:23
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/aws-sdk/lib/credentials.js:216:15
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:75:11) {
aws-cdk:   code: 'ProcessCredentialsProviderFailure',
aws-cdk:   time: 2020-12-10T21:09:29.025Z
aws-cdk: }
aws-cdk: Unable to determine AWS region from environment or AWS configuration (profile: "default"), defaulting to 'us-east-1'
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Unable to determine the default AWS account: Error: Something is wrong here
aws-cdk:     at Object.<anonymous> (/Users/rdjurasaj/code/robertd/aws-cdk/packages/aws-cdk/test/api/sdk-provider.test.js:519:28)
aws-cdk:     at Object.asyncJestTest (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/queueRunner.js:45:12
aws-cdk:     at new Promise (<anonymous>)
aws-cdk:     at mapper (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/queueRunner.js:75:41
aws-cdk:     at processTicksAndRejections (node:internal/process/task_queues:93:5)
aws-cdk: Unable to determine AWS region from environment or AWS configuration (profile: "default"), defaulting to 'us-east-1'
aws-cdk: Resolving default credentials
aws-cdk: Looking up default account ID from STS
aws-cdk: Unable to determine the default AWS account: Error: Something is wrong here
aws-cdk:     at Object.<anonymous> (/Users/rdjurasaj/code/robertd/aws-cdk/packages/aws-cdk/test/api/sdk-provider.test.js:530:28)
aws-cdk:     at Object.asyncJestTest (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/queueRunner.js:45:12
aws-cdk:     at new Promise (<anonymous>)
aws-cdk:     at mapper (/Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
aws-cdk:     at /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest-jasmine2/build/queueRunner.js:75:41
aws-cdk: Using test plugin credentials for account (82d6be29-f68d-42f4-b8e5-99558070be5f)plugin_account_#
aws-cdk: PASS test/api/deploy-stack.test.js (9.895 s)
aws-cdk: PASS test/api/sdk-provider.test.js (9.965 s)
aws-cdk: Test-Stack-A
aws-cdk: PASS test/context.test.js
aws-cdk:   ● Console
aws-cdk:     console.log
aws-cdk:       Temporary working directory: /var/folders/qy/4g09xft92tl4920lgkhc111c00265b/T/aws-cdk-testR9y8KG
aws-cdk:       at Object.<anonymous> (test/context.test.ts:15:11)
aws-cdk:     console.log
aws-cdk:       Switching back to /Users/rdjurasaj/code/robertd/aws-cdk/packages/aws-cdk cleaning up /var/folders/qy/4g09xft92tl4920lgkhc111c00265b/T/aws-cdk-testR9y8KG
aws-cdk:       at Object.<anonymous> (test/context.test.ts:22:11)
aws-cdk: Test-Stack-A: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-A
aws-cdk: Outputs:
aws-cdk: Test-Stack-A.StackName = Test-Stack-A
aws-cdk: Stack ARN:
aws-cdk: Test-Stack-B
aws-cdk: Test-Stack-B: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-B
aws-cdk: Outputs:
aws-cdk: Test-Stack-B.StackName = Test-Stack-B
aws-cdk: Stack ARN:
aws-cdk: Test-Stack-A: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-A
aws-cdk: Outputs:
aws-cdk: Test-Stack-A.StackName = Test-Stack-A
aws-cdk: Stack ARN:
aws-cdk: Test-Stack-A
aws-cdk: Test-Stack-A: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-A
aws-cdk: Outputs:
aws-cdk: Test-Stack-A.StackName = Test-Stack-A
aws-cdk: Stack ARN:
aws-cdk: Test-Stack-B
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-A/MockedOut
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-B/MockedOut
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-A/MockedOut
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-A/MockedOut
aws-cdk: Test-Stack-B: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-B
aws-cdk: Outputs:
aws-cdk: Test-Stack-B.StackName = Test-Stack-B
aws-cdk: Stack ARN:
aws-cdk: Test-Stack-A
aws-cdk: Test-Stack-A: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-A
aws-cdk: Outputs:
aws-cdk: Test-Stack-A.StackName = Test-Stack-A
aws-cdk: Stack ARN:
aws-cdk: Test-Stack-B
aws-cdk: Test-Stack-B: deploying...
aws-cdk:
aws-cdk:  ✅  Test-Stack-B
aws-cdk: Outputs:
aws-cdk: Test-Stack-B.StackName = Test-Stack-B
aws-cdk: Stack ARN:
aws-cdk:  ⏳  Bootstrapping environment aws://56789/south-pole...
aws-cdk:  ✅  Environment aws://56789/south-pole bootstrapped.
aws-cdk:  ⏳  Bootstrapping environment aws://123456789012/bermuda-triangle-1...
aws-cdk:  ✅  Environment aws://123456789012/bermuda-triangle-1 bootstrapped.
aws-cdk:  ⏳  Bootstrapping environment aws://123456789012/west-pole...
aws-cdk:  ✅  Environment aws://123456789012/west-pole bootstrapped.
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-B/MockedOut
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-A/MockedOut
aws-cdk: arn:aws:cloudformation:::stack/Test-Stack-B/MockedOut
aws-cdk: PASS test/cdk-toolkit.test.js (5.631 s)
aws-cdk: PASS test/assets.test.js
aws-cdk: PASS test/util/awscli-compatible.test.js
aws-cdk: PASS test/version.test.js
aws-cdk: PASS test/context-providers/security-groups.test.js
aws-cdk: Including dependency stacks: A
aws-cdk: There were no differences
aws-cdk: Including dependency stacks: A
aws-cdk: [Error at /resource] this is an error
aws-cdk: PASS test/util/stack-monitor.test.js
aws-cdk: Searching for AMI in 1234:asdf
aws-cdk: PASS test/diff.test.js
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: --app points to a cloud assembly, so we bypass synth
aws-cdk: Searching for AMI in 1234:asdf
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: --app points to a cloud assembly, so we bypass synth
aws-cdk: PASS test/api/cloud-executable.test.js
aws-cdk: PASS test/context-providers/amis.test.js
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: --app points to a cloud assembly, so we bypass synth
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: --app points to a cloud assembly, so we bypass synth
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: outdir: cdk.out
aws-cdk: env: {
aws-cdk:   CDK_DEFAULT_REGION: 'bermuda-triangle-1337',
aws-cdk:   CDK_DEFAULT_ACCOUNT: '123456789012',
aws-cdk:   CDK_DEBUG: 'true',
aws-cdk:   CDK_CONTEXT_JSON: '{"aws:cdk:enable-path-metadata":true,"aws:cdk:enable-asset-metadata":true,"aws:cdk:version-reporting":true,"aws:cdk:bundling-stacks":["*"]}',
aws-cdk:   CDK_OUTDIR: 'cdk.out',
aws-cdk:   CDK_CLI_ASM_VERSION: '7.0.0',
aws-cdk:   CDK_CLI_VERSION: '0.0.0'
aws-cdk: }
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: Not a file: 'does-not-exist'. Using 'does-not-exist' as command-line
aws-cdk: outdir: cdk.out
aws-cdk: env: {
aws-cdk:   CDK_DEFAULT_REGION: 'bermuda-triangle-1337',
aws-cdk:   CDK_DEFAULT_ACCOUNT: '123456789012',
aws-cdk:   CDK_DEBUG: 'true',
aws-cdk:   CDK_CONTEXT_JSON: '{"aws:cdk:enable-path-metadata":true,"aws:cdk:enable-asset-metadata":true,"aws:cdk:version-reporting":true,"aws:cdk:bundling-stacks":["*"]}',
aws-cdk:   CDK_OUTDIR: 'cdk.out',
aws-cdk:   CDK_CLI_ASM_VERSION: '7.0.0',
aws-cdk:   CDK_CLI_VERSION: '0.0.0'
aws-cdk: }
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: outdir: cdk.out
aws-cdk: env: {
aws-cdk:   CDK_DEFAULT_REGION: 'bermuda-triangle-1337',
aws-cdk:   CDK_DEFAULT_ACCOUNT: '123456789012',
aws-cdk:   CDK_DEBUG: 'true',
aws-cdk:   CDK_CONTEXT_JSON: '{"aws:cdk:enable-path-metadata":true,"aws:cdk:enable-asset-metadata":true,"aws:cdk:version-reporting":true,"aws:cdk:bundling-stacks":["*"]}',
aws-cdk:   CDK_OUTDIR: 'cdk.out',
aws-cdk:   CDK_CLI_ASM_VERSION: '7.0.0',
aws-cdk:   CDK_CLI_VERSION: '0.0.0'
aws-cdk: }
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: outdir: cdk.out
aws-cdk: env: {
aws-cdk:   CDK_DEFAULT_REGION: 'bermuda-triangle-1337',
aws-cdk:   CDK_DEFAULT_ACCOUNT: '123456789012',
aws-cdk:   CDK_DEBUG: 'true',
aws-cdk:   CDK_CONTEXT_JSON: '{"aws:cdk:enable-path-metadata":true,"aws:cdk:enable-asset-metadata":true,"aws:cdk:version-reporting":true,"aws:cdk:bundling-stacks":["*"]}',
aws-cdk:   CDK_OUTDIR: 'cdk.out',
aws-cdk:   CDK_CLI_ASM_VERSION: '7.0.0',
aws-cdk:   CDK_CLI_VERSION: '0.0.0'
aws-cdk: }
aws-cdk: Setting "CDK_DEFAULT_REGION" environment variable to bermuda-triangle-1337
aws-cdk: Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
aws-cdk: context: {
aws-cdk:   'aws:cdk:enable-path-metadata': true,
aws-cdk:   'aws:cdk:enable-asset-metadata': true,
aws-cdk:   'aws:cdk:version-reporting': true,
aws-cdk:   'aws:cdk:bundling-stacks': [ '*' ]
aws-cdk: }
aws-cdk: outdir: cdk.out
aws-cdk: env: {
aws-cdk:   CDK_DEFAULT_REGION: 'bermuda-triangle-1337',
aws-cdk:   CDK_DEFAULT_ACCOUNT: '123456789012',
aws-cdk:   CDK_DEBUG: 'true',
aws-cdk:   CDK_CONTEXT_JSON: '{"aws:cdk:enable-path-metadata":true,"aws:cdk:enable-asset-metadata":true,"aws:cdk:version-reporting":true,"aws:cdk:bundling-stacks":["*"]}',
aws-cdk:   CDK_OUTDIR: 'cdk.out',
aws-cdk:   CDK_CLI_ASM_VERSION: '7.0.0',
aws-cdk:   CDK_CLI_VERSION: '0.0.0'
aws-cdk: }
aws-cdk: PASS test/api/exec.test.js (7.353 s)
aws-cdk: PASS test/settings.test.js
aws-cdk: Context found in cdk.json:
aws-cdk: ┌───┬─────┬───────┐
aws-cdk: │ # │ Key │ Value │
aws-cdk: ├───┼─────┼───────┤
aws-cdk: │ 1 │ foo │ "bar" │
aws-cdk: └───┴─────┴───────┘
aws-cdk: Run cdk context --reset KEY_OR_NUMBER to remove a context key. It will be refreshed on the next CDK synthesis run.
aws-cdk: Context value foo reset. It will be refreshed on next synthesis
aws-cdk: Context value baz reset. It will be refreshed on next synthesis
aws-cdk: PASS test/commands/context-command.test.js
aws-cdk: https://docs.aws.amazon.com/cdk/api/latest/
aws-cdk: https://docs.aws.amazon.com/cdk/api/latest/
aws-cdk: [Error at /resource] this is an error
aws-cdk: PASS test/cdk-docs.test.js
aws-cdk:   ● Console
aws-cdk:     console.warn
aws-cdk:       WARNING: Replacing existing mock for module: ../../lib/logging
aws-cdk:        9 | describe('`cdk docs`', () => {
aws-cdk:       10 |   beforeEach(done => {
aws-cdk:     > 11 |     mockery.registerMock('../../lib/logging', {
aws-cdk:          |             ^
aws-cdk:       12 |       debug() { return; },
aws-cdk:       13 |       error() { return; },
aws-cdk:       14 |       print() { return; },
aws-cdk:       at Object.registerMock (../../node_modules/mockery/mockery.js:232:13)
aws-cdk:       at Object.<anonymous> (test/cdk-docs.test.ts:11:13)
aws-cdk: PASS test/util/cloudformation.test.js
aws-cdk: ℹ️ CDK Version: 0.0.0 (build c728dc3)
aws-cdk: ℹ️ AWS environment variables:
aws-cdk:   - AWS_PAGER =
aws-cdk:   - AWS_REGION = us-west-2
aws-cdk: ℹ️ CDK environment variables:
aws-cdk:   - CDK_DISABLE_STACK_TRACE = 1
aws-cdk: PASS test/cdk-doctor.test.js
aws-cdk: PASS test/api/cloud-assembly.test.js
aws-cdk: PASS test/yaml.test.js
aws-cdk: PASS test/util/arrays.test.js
aws-cdk: PASS test/util/applydefaults.test.js
aws-cdk: PASS test/util/console-formatters.test.js
aws-cdk: PASS test/integ/cli/resource-pool.test.js
aws-cdk: PASS test/util/objects.test.js
aws-cdk: PASS test/context-providers/generic.test.js
aws-cdk: PASS test/serialize.test.js
aws-cdk: PASS test/api/cloudformation-deployments.test.js
aws-cdk: PASS test/account-cache.test.js (10.328 s)
aws-cdk: =============================== Coverage summary ===============================
aws-cdk: Statements   : 74.85% ( 2193/2930 )
aws-cdk: Branches     : 62.88% ( 1106/1759 )
aws-cdk: Functions    : 77.8% ( 445/572 )
aws-cdk: Lines        : 75.65% ( 2091/2764 )
aws-cdk: ================================================================================
aws-cdk: Summary of all failing tests
aws-cdk: FAIL test/init.test.js
aws-cdk:   ● v1 tests › verify "future flags" are added to cdk.json
aws-cdk:     Could not add project AwsCdkTestD9Pe7S.csproj to solution AwsCdkTestD9Pe7S.sln. Error code: 127
aws-cdk:       at ChildProcess.<anonymous> (../../../../../../../private/var/folders/qy/4g09xft92tl4920lgkhc111c00265b/T/aws-cdk-testD9PE7s/tmp/add-project.hook.ts:29:16)
aws-cdk:   ● v2 tests › verify "future flags" are added to cdk.json
aws-cdk:     Could not add project AwsCdkTestv6KZel.csproj to solution AwsCdkTestv6KZel.sln. Error code: 127
aws-cdk:       at ChildProcess.<anonymous> (../../../../../../../private/var/folders/qy/4g09xft92tl4920lgkhc111c00265b/T/aws-cdk-testv6kZEL/tmp/add-project.hook.ts:29:16)
aws-cdk: Test Suites: 1 failed, 34 passed, 35 total
aws-cdk: Tests:       2 failed, 256 passed, 258 total
aws-cdk: Snapshots:   0 total
aws-cdk: Time:        17.78 s, estimated 27 s
aws-cdk: Ran all test suites.
aws-cdk: Error: /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest/bin/jest.js exited with error code 1
aws-cdk: Tests failed. Total time (18.6s) | /Users/rdjurasaj/code/robertd/aws-cdk/node_modules/jest/bin/jest.js (18.5s)
aws-cdk: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
aws-cdk: npm ERR! code 1
aws-cdk: npm ERR! path /Users/rdjurasaj/code/robertd/aws-cdk/packages/aws-cdk
aws-cdk: npm ERR! command failed
aws-cdk: npm ERR! command sh -c cdk-test
aws-cdk: npm ERR! A complete log of this run can be found in:
aws-cdk: npm ERR!     /Users/rdjurasaj/.npm/_logs/2020-12-10T21_09_36_221Z-debug.log
aws-cdk: error Command failed with exit code 1.
aws-cdk: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

skinny85 · 2020-12-10T21:24:28Z

@robertd try installing .NET Core locally (or use Gitpod 🙂) to get rid of that error.

robertd · 2020-12-10T21:29:16Z

@skinny85 By "build locally" I meant using docker container build... I'll definitely look into Gitpod since I'm not familiar with .NET Core 😃

robertd · 2020-12-10T22:02:12Z

@skinny85 This been an ongoing issue (at least for me) #6406 ... so sorry for the topic derailment in here 😄 . Will definitely look into Gitpod for sure 😃

robertd · 2020-12-10T22:04:11Z

I've ran yarn integ integ.http-origin.js integ.load-balancer-origin.js integ.origin-group.js but I can't really create VPC or public load balancer in our AWS account to truly test these. Hopefully the latest few commits I've made will fix the integration tests. 😄

njlynch

Looks good!

One comment -- this should have been the default value already, but it wasn't. I've marked this as a -- and the last! -- breaking change. There is a (unlikely) potential for someone with an old web server out there being impacted by this.

mergify · 2020-12-11T11:12:47Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…ocol

aws-cdk-automation · 2020-12-11T11:43:06Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 43c365d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-12-11T11:43:32Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…col (aws#11997) closes aws#11994 BREAKING CHANGE: Default minimum origin SSL protocol for `HttpOrigin` and `LoadBalancerOrigin` changed from SSLv3 to TLSv1.2. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Dec 10, 2020

github-actions bot assigned njlynch Dec 10, 2020

robertd changed the title ~~feat(cloudfront): ability to specify minimal origin SSL protocol~~ feat(cloudfront): ability to specify minimum origin SSL protocol Dec 10, 2020

feat(cloudfront): ability to specify minimum origin SSL protocol

c728dc3

robertd force-pushed the robertd/cloudfront-origin-minimum-ssl-protocol branch from 2b343d7 to c728dc3 Compare December 10, 2020 20:11

robertd added 2 commits December 10, 2020 14:50

fix integration tests

737db14

fix additional integration test

47540c7

njlynch changed the title ~~feat(cloudfront): ability to specify minimum origin SSL protocol~~ feat(cloudfront-origins): ability to specify minimum origin SSL protocol Dec 11, 2020

github-actions bot added the @aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library label Dec 11, 2020

njlynch added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 11, 2020

njlynch approved these changes Dec 11, 2020

View reviewed changes

Merge branch 'master' into robertd/cloudfront-origin-minimum-ssl-prot…

43c365d

…ocol

mergify bot merged commit a0aa61d into aws:master Dec 11, 2020

robertd deleted the robertd/cloudfront-origin-minimum-ssl-protocol branch December 11, 2020 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cloudfront-origins): ability to specify minimum origin SSL protocol #11997

feat(cloudfront-origins): ability to specify minimum origin SSL protocol #11997

robertd commented Dec 10, 2020 •

edited by njlynch

Loading

gitpod-io bot commented Dec 10, 2020 •

edited

Loading

robertd commented Dec 10, 2020

skinny85 commented Dec 10, 2020

robertd commented Dec 10, 2020 •

edited

Loading

skinny85 commented Dec 10, 2020

robertd commented Dec 10, 2020 •

edited

Loading

robertd commented Dec 10, 2020 •

edited

Loading

robertd commented Dec 10, 2020

njlynch left a comment

mergify bot commented Dec 11, 2020

aws-cdk-automation commented Dec 11, 2020

mergify bot commented Dec 11, 2020

feat(cloudfront-origins): ability to specify minimum origin SSL protocol #11997

feat(cloudfront-origins): ability to specify minimum origin SSL protocol #11997

Conversation

robertd commented Dec 10, 2020 • edited by njlynch Loading

gitpod-io bot commented Dec 10, 2020 • edited Loading

robertd commented Dec 10, 2020

skinny85 commented Dec 10, 2020

robertd commented Dec 10, 2020 • edited Loading

skinny85 commented Dec 10, 2020

robertd commented Dec 10, 2020 • edited Loading

robertd commented Dec 10, 2020 • edited Loading

robertd commented Dec 10, 2020

njlynch left a comment

Choose a reason for hiding this comment

mergify bot commented Dec 11, 2020

aws-cdk-automation commented Dec 11, 2020

AWS CodeBuild CI Report

mergify bot commented Dec 11, 2020

robertd commented Dec 10, 2020 •

edited by njlynch

Loading

gitpod-io bot commented Dec 10, 2020 •

edited

Loading

robertd commented Dec 10, 2020 •

edited

Loading

robertd commented Dec 10, 2020 •

edited

Loading

robertd commented Dec 10, 2020 •

edited

Loading