Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cloudfront): Specify the minimum origin SSL protocol version in the new Distribution construct #11994

Closed
robertd opened this issue Dec 10, 2020 · 2 comments · Fixed by #11997
Closed

(cloudfront): Specify the minimum origin SSL protocol version in the new Distribution construct #11994

robertd opened this issue Dec 10, 2020 · 2 comments · Fixed by #11997
Assignees
@njlynch
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@robertd
Copy link
Contributor

robertd commented Dec 10, 2020 •
edited
Loading

❓ General Issue

Is it possible to specify the minimum origin SSL protocol version in the new Distribution construct natively? (without using the escape hatches 😄 )Currently it defaults to SSLv3.

image

cc @njlynch

The Question

Environment

  • CDK CLI Version: 1.77.0 (build a941c53)
  • Node.js Version: v15.3.0
  • OS: macOS Mojave
  • Language (Version): TypeScript (4.0.3)
@robertd robertd added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Dec 10, 2020
@njlynch njlynch changed the title (cloudfront): How to specify the minimum origin SSL protocol version in the new Distribution construct (cloudfront): Specify the minimum origin SSL protocol version in the new Distribution construct Dec 10, 2020
@njlynch njlynch added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2020
@njlynch
Copy link
Contributor

njlynch commented Dec 10, 2020

Nope, there's not a way to do this without escape hatches at the moment.

Re-tagging this as a feature request. Should be a relatively minor feature to add a prop for the SSL protocol version.

@robertd robertd mentioned this issue Dec 10, 2020
Merged
@mergify mergify bot closed this as completed in #11997 Dec 11, 2020
mergify bot pushed a commit that referenced this issue Dec 11, 2020
@robertd
feat(cloudfront-origins): ability to specify minimum origin SSL proto…
a0aa61d 
…col (#11997)

closes #11994 

BREAKING CHANGE: Default minimum origin SSL protocol for `HttpOrigin` and `LoadBalancerOrigin` changed from SSLv3 to TLSv1.2.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@robertd @flochaz
feat(cloudfront-origins): ability to specify minimum origin SSL proto…
032c6e4 
…col (aws#11997)

closes aws#11994 

BREAKING CHANGE: Default minimum origin SSL protocol for `HttpOrigin` and `LoadBalancerOrigin` changed from SSLv3 to TLSv1.2.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudfront-origins): ability to specify minimum origin SSL protocol robertd/aws-cdk
2 participants
@robertd @njlynch