Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfnspec): add missing CodeArtifact properties #11804

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Dec 1, 2020

The spec for CodeArtifact is currently missing one required property
(Repository.domainName) and two other optional properties. This patch adds the
missing properties until the spec is updated.

fixes #11790
related #11569


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The spec for CodeArtifact is currently missing one required property
(`Repository.domainName`) and two other optional properties. This patch adds the
missing properties until the spec is updated.

fixes #11790
related #11569
@njlynch njlynch requested a review from a team December 1, 2020 12:36
@njlynch njlynch self-assigned this Dec 1, 2020
@gitpod-io
Copy link

gitpod-io bot commented Dec 1, 2020

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7526fbb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0d47c49 into master Dec 1, 2020
@mergify mergify bot deleted the njlynch/patch-codeartifact-cfnspec branch December 1, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/cfnspec contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-codeartifact): CfnRepository is missing DomainName parameter?
4 participants