Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeArtifact] CfnRepository cannot be deployed (missing required CFN param DomainName) #11569

Closed
troyready opened this issue Nov 19, 2020 · 4 comments
Closed

[CodeArtifact] CfnRepository cannot be deployed (missing required CFN param DomainName) #11569

troyready opened this issue Nov 19, 2020 · 4 comments
Assignees
@njlynch
Labels
@aws-cdk/aws-codeartifact Related to the @aws-cdk/aws-codeartifact package bug This issue is a bug.

Comments

@troyready
Copy link

As of v1.74.0, a CodeArtifact Repository cannot currently be created because it's missing the required DomainName parameter. Using the CfnRepository resource generates an error:

Model validation failed (#: required key [DomainName] not found)

It looks like this is fixed in the WIP L2 PR in commit 4489488. It might be best to pull this out of the PR to get it included faster to make the basic CFN resources usable.
@troyready troyready added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2020
@github-actions github-actions bot added the @aws-cdk/aws-codeartifact Related to the @aws-cdk/aws-codeartifact package label Nov 19, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Nov 20, 2020

So the CloudFormation spec for CodeArtifact is missing properties? If so, we should submit an issue so they can fix it on the spec level. Their spec is open source, and hosted in the cloudformation repo.

@NetaNir NetaNir added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 20, 2020
@troyready
Copy link
Author

I'm not super familiar with the CFN resource provider setup, but from what I can see it already looks correct to me in the upstream repo, but that isn't reflected in the published spec.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 20, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Nov 20, 2020

One the spec is published it will imported to the aws cdk.

@NetaNir NetaNir closed this as completed Nov 20, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

njlynch added a commit that referenced this issue Dec 1, 2020
@njlynch
fix(cfnspec): add missing CodeArtifact properties
9ea3cfb 
The spec for CodeArtifact is currently missing one required property
(`Repository.domainName`) and two other optional properties. This patch adds the
missing properties until the spec is updated.

fixes #11790
related #11569
njlynch added a commit that referenced this issue Dec 1, 2020
@njlynch
chore(cfnspec): add missing CodeArtifact properties
7526fbb 
The spec for CodeArtifact is currently missing one required property
(`Repository.domainName`) and two other optional properties. This patch adds the
missing properties until the spec is updated.

fixes #11790
related #11569
@njlynch njlynch mentioned this issue Dec 1, 2020
Merged
mergify bot pushed a commit that referenced this issue Dec 1, 2020
@njlynch
chore(cfnspec): add missing CodeArtifact properties (#11804)
0d47c49 
The spec for CodeArtifact is currently missing one required property
(`Repository.domainName`) and two other optional properties. This patch adds the
missing properties until the spec is updated.

fixes #11790
related #11569

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-codeartifact Related to the @aws-cdk/aws-codeartifact package bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@njlynch @troyready @NetaNir