fix(appsync): HttpDataSource extends BackedDataSource instead of BaseDataSource #11185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BryanPan342
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
@MrArnoldPalmer this LGTM, maybe a test case is needed but other than that im good with it
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
1 task
This was referenced Nov 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…DataSourceProps` (#32065) ### Reason for this change Closes #31979. Replaces #29689. In #11185, the `HttpDataSource` class was updated to extend `BackedDataSource` instead of `BaseDataSource`, however the `HttpDataSourceProps` type wasn't updated to reflect this change. This PR makes the `HttpDataSourceProps` type reflect the change. ### Description of changes Makes the `HttpDataSourceProps` type extend `BackedDataSourceProps`, instead of `BaseDataSourceProps`. This means users are able to provide the `serviceRole` prop without getting a type error. ### Description of how you validated changes The below code snippet no longer gives an incorrect type error when providing the serviceRole, as it did before: ```ts import * as appsync from "aws-cdk-lib/aws-appsync"; import type { IRole } from "aws-cdk-lib/aws-iam"; declare const myApi: appsync.GraphqlApi; declare const serviceRole: IRole; const stepFunctionHttpDataSource = new appsync.HttpDataSource( myApi, "MyStepFunctionHTTPDataSource", { api: myApi, authorizationConfig: { signingRegion: "eu-west-1", signingServiceName: "states", }, endpoint: `https://states.eu-west-1.amazonaws.com`, name: "StepFunctionHTTPDataSource", // Providing the `serviceRole` now correctly DOESN'T throw a type error serviceRole, } ); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackedDataSource make Grantable HttpDataSource. I think this pr allows better use of the iam config: #10171
fixes #11183