chore(release): 1.69.0 #10958
Closed
chore(release): 1.69.0 #10958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a merge PR three times a week (M/W/F) to forward merge master onto 'v2-main'. Mergify configuration to automatically merge the PR if there are no conflicts and the sanity build succeeds.
following guidance from GHSA-269g-pwp5-87pp Affected versions include junit < 4.13.1 verification: created java init projects and ensured they successfully run tests using `mvn package` and deployed them to CloudFormation. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
>This is a fix for the README in the Kinesis event source example. This removes the undeclared variable `queue` from the example and replaces it with the `stream`. This is a simple typo pointing to a variable that was not declared in the example for Kinesis. The motivation for this change is: - To ensure developers have accurate documentation. - To ensure developers have a good experience when attempting to understand the features of the CDK from the documentation. There is a convention in the README's to refer to variables outside the scope of the example e.g. ```ts myFunction.addEventSource( //etc ``` Where `myFunction` is not declared in the scope of the example. This fix prevents the assumption that a `queue` resource has also been created outside the scope of the example. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows setting the description for HttpAPI. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This will be moved to cdk-ops as a CodeBuild job. The benefits are that (a) we can add alarms when this job fails, (b) it doesn't run (and fail) on customers' Github forks and, (c) besides the scheduled runs it can also be manually triggered.
Because of concurrent running of integration tests, the account cache (which is supposed to be a JSON file) can be read in a state where it's empty or incompletely written, which fails the JSON parse. If that happens, ignore the error and pretend the cache is empty. Fixes sporadic concurrency issues in the integration tests. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes: #10906 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### What's new? 1. Added `.scripts/gen.sh` - execute this to execute `gen` all modules, for cfn modules this will usually execute `cfn2ts`. This also means that you can use it to generate all required files to build `monocdk`: ``` ./scripts/gen.sh lerna build --scope monocdk ``` 2. `cdk-build` will now execute the command specified in the package `script.gen` directive. 3. `cdk-build.pre` - The commands in the `pre` array are now concatenated using `&&`. This PR includes changes to many files the majority of them are `package.json` files. Summary of changes: 1. Added a `gen` as an npm script target to all cfn modules. The `gen` target is already used in our repo as a convention for executing pre build command for code generation. This change extends it to include executing `cfn2ts`. Prior to this change we were executing the `pre` commands in `cdk-build`, followed by executing `cfn2ts` on cfn modules. `cdk-build` now execute `gen` unless `--skip-gen` is passed. 2. All code generation command (non `cfn2ts`) were moved from `pre` in `cdk-build` to `gen`. The only remaining `pre` directives are those unrelated to code generation such as cleaning commands. **Why?** This will allow us to execute `lerna run --stream gen` to execute all required code generation scripts on all modules. 2. The `cfn2ts` script **already** includes the ability to auto detect the CloudFormation scope from `cdk-build` clause in the `package.json`: https://github.com/aws/aws-cdk/blob/bc096f08dd1dc29a0bb320b5798b0d7bee5e3161/tools/cfn2ts/bin/cfn2ts.ts#L43-L46 which makes it redundant to execute `cfn2ts --scope=scope` . 3. Since the `gen` directive is now required in all cfn module, it was added to `cfnspec` so it will be added to every new module. 5. Added a `gen.sh` script in `scripts`, executing it will build `cfn2ts` and then execute `lerna gen`. This is useful if one wants to only get the `.generated` files without running a full build. This PR originally included the changes require to split the monocdk build, these were removed from this PR to make it easier to review. The monocdk build related changes will be submitted in a different PR. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#10933) To avoid forcing a `cdk8s` dependency on the monolithic packages, we don't directly use `cdk8s.Chart` in the EKS integration. Instead, we use a generic `Construct` and assert at runtime that it indeed a cdk8s chart. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The self-mutation feature of the `CdkPipeline` might at times get in the way of the pipeline development workflow. Each change to the pipeline must be pushed to git, otherwise, after the pipeline was updated using `cdk deploy`, it will automatically revert to the state found in git.
To make the development more convenient, the self-mutation feature can be turned off temporarily, by passing `selfMutating: false` property, example:
```ts
const pipeline = new CdkPipeline(this, 'Pipeline', {
selfMutating: false,
...
});
```
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Expects generic `RestApiBase` instead of `RestApi` at `BasePathMapping` creation - Fixes #10300 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…10946) The [AutoPullRequest] CodeBuild job already checks out the base branch. This causes the `git checkout -b` command to fail since the branch already exists. Update the script so that branch creation occurs only if it does not already exist. [AutoPullRequest]: https://github.com/aws/cdk-ops/blob/21acd7ff37ad9ab14d8c3f9b41980e9f62f64503/lib/cdk-pipeline.ts#L284-L290 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Note: No functional change to the tests or the set of tests. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [yargs](https://github.com/yargs/yargs) from 16.0.3 to 16.1.0. - [Release notes](https://github.com/yargs/yargs/releases) - [Changelog](https://github.com/yargs/yargs/blob/master/CHANGELOG.md) - [Commits](yargs/yargs@v16.0.3...v16.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
aws-cdk-automation
added
the
pr/no-squash
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG