Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): cdk context --reset <number> does not work #10753

Merged
merged 2 commits into from
Oct 19, 2020
Merged

fix(cli): cdk context --reset <number> does not work #10753

merged 2 commits into from
Oct 19, 2020

Conversation

diesal11
Copy link
Contributor

@diesal11 diesal11 commented Oct 7, 2020 •
edited
Loading

This PR fixes #3033 while also addressing the issues that arose from #10619

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@diesal11 diesal11 mentioned this pull request Oct 7, 2020
Merged
@diesal11 diesal11 changed the title fix(cli): 'cdk context --reset <number>' does not work fix(cli): cdk context --reset <number> does not work Oct 7, 2020
@diesal11 diesal11 force-pushed the fix/context-reset-number branch 3 times, most recently from 7881601 to 1e88242 Compare October 7, 2020 07:06
@diesal11 diesal11 force-pushed the fix/context-reset-number branch from 1e88242 to dad6d8b Compare October 7, 2020 08:19
@diesal11
Copy link
Contributor Author

Hey @rix0rrr, any update on this?

I see a new release was pushed today, any reason why this wasn't included? This command has been broken for well over a year now and it would be great to see a fix implemented.

@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 19, 2020

I lost trust in the change because of the previous mishap, and I didn't have time to look at it before, which is why this has been lingering.

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@gitpod-io
Copy link

gitpod-io bot commented Oct 19, 2020

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c2933b1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2f3a167 into aws:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk context --reset <number> does not work
4 participants
@diesal11 @rix0rrr @aws-cdk-automation @NetaNir