Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli/pipelines] Describe bootstrapping protocol #9681

Closed
rix0rrr opened this issue Aug 13, 2020 · 1 comment
Closed

[cli/pipelines] Describe bootstrapping protocol #9681

rix0rrr opened this issue Aug 13, 2020 · 1 comment
Assignees
@rix0rrr
Labels
@aws-cdk/pipelines CDK Pipelines library documentation This is a problem with documentation. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Milestone
[GA] CDK Pipelines

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 13, 2020 •
edited
Loading

Describe bootstrapping, what it does, what it needs, and specifically:

How to customize

We need this in order to close all the "I need such and such bootstrap customization" issues.

There are very many of those, including multiple "enable encryption"/"disable encryption"/"import existing bucket" ones. They will all be resolved.

This is a 📕 documentation issue
@rix0rrr rix0rrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. documentation This is a problem with documentation. @aws-cdk/pipelines CDK Pipelines library p1 package/tools Related to AWS CDK Tools or CLI effort/medium Medium work item – several days of effort labels Aug 13, 2020
@rix0rrr rix0rrr added this to the [CLI] Soon milestone Aug 13, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Aug 13, 2020
@ghost ghost self-assigned this Aug 14, 2020
@rix0rrr rix0rrr mentioned this issue Aug 21, 2020
Merged
mergify bot pushed a commit that referenced this issue Aug 31, 2020
@rix0rrr
feat(bootstrap): customizable bootstrap template (#9886)
2596ef7 
There are many requests for customization of the built-in bootstrapping
template. Rather than implementing each and every request, it's more
productive to allow users to help themselves.

This change introduces two new flags to `cdk bootstrap`:

* `cdk bootstrap --show-template`: prints the current template to
  stdout, which people can pipe to a file.
* `cdk bootstrap --template FILE`: reads the template from a file
  instead of using the built-in template.

This can be used to arbitrarily customize the bootstrapping template
for use in any organization.

I know that the documentation changes in this PR are pretty light,
but really a Developer Guide topic should be written on bootstrapping,
which is next on my TODO list.

Resolves #9256, resolves #8724, resolves #3684, resolves #1528, necessary for #9681.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@ghost
Copy link

ghost commented Sep 12, 2020

This is now in the Developer Guide.

https://docs.aws.amazon.com/cdk/latest/guide/bootstrapping.html

@ghost ghost closed this as completed Sep 12, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/pipelines CDK Pipelines library documentation This is a problem with documentation. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
[GA] CDK Pipelines
Development

No branches or pull requests
2 participants
@rix0rrr @SomayaB