-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toolkit: allow customizing bucket encryption in toolkit bucket #1528
Labels
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p1
package/tools
Related to AWS CDK Tools or CLI
Comments
cybergoof
changed the title
Request: "CDK deploy support S3 Put Object parameters
Request: "CDK deploy" support S3 Put Object parameters
Jan 12, 2019
eladb
changed the title
Request: "CDK deploy" support S3 Put Object parameters
toolkit: allow customizing bucket encryption in toolkit bucket
Jan 13, 2019
Renamed to reflect the intent rather mechanism |
eladb
added
feature-request
A feature should be added or improved.
package/tools
Related to AWS CDK Tools or CLI
labels
Jan 13, 2019
Hi, any news on this topic? We also need this feature badly for our enterprise environment. |
Hi, I can see if I can implement this. @eladb Any special wishes what to do and what not to do? |
Any update on this? I see in the docs: cdk bootstrap
cdk bootstrap [ENVIRONMENTS..]
Deploys the CDK toolkit stack into an AWS environment
Options:
--bootstrap-bucket-name, -b, The name of the CDK toolkit bucket
--toolkit-bucket-name [string]
--bootstrap-kms-key-id AWS KMS master key ID used for the
SSE-KMS encryption [string]
--tags, -t Tags to add for the stack
(KEY=VALUE) [array] [default: []]
--execute Whether to execute ChangeSet
(--no-execute will NOT execute the
ChangeSet) [boolean] [default: true] Looks like we can pass a KMS key to the bootstrap command but then deploy doesn't use it? Not sure if I'm missing something obvious here. |
mergify bot
pushed a commit
that referenced
this issue
Aug 31, 2020
There are many requests for customization of the built-in bootstrapping template. Rather than implementing each and every request, it's more productive to allow users to help themselves. This change introduces two new flags to `cdk bootstrap`: * `cdk bootstrap --show-template`: prints the current template to stdout, which people can pipe to a file. * `cdk bootstrap --template FILE`: reads the template from a file instead of using the built-in template. This can be used to arbitrarily customize the bootstrapping template for use in any organization. I know that the documentation changes in this PR are pretty light, but really a Developer Guide topic should be written on bootstrapping, which is next on my TODO list. Resolves #9256, resolves #8724, resolves #3684, resolves #1528, necessary for #9681. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p1
package/tools
Related to AWS CDK Tools or CLI
Request that when running
cdk deploy
, that s3 bucket name and --sse/--sse-kms-key-id be optional parameters. I need the ability to specify how the Cloudformation template is stored in the staging S3.The text was updated successfully, but these errors were encountered: