Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-elasticloadbalancingv2): NetworkTargetGroupProps does not expose connection_termination attribute #17010

Closed
2 tasks
Avinm opened this issue Oct 15, 2021 · 4 comments · Fixed by #20821
Closed
2 tasks

(aws-elasticloadbalancingv2): NetworkTargetGroupProps does not expose connection_termination attribute #17010

Avinm opened this issue Oct 15, 2021 · 4 comments · Fixed by #20821
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@Avinm
Copy link

Avinm commented Oct 15, 2021

Description

CDK does not expose a mechanism to set deregistration_delay.connection_termination.enabled property for NLB targets.

deregistration_delay.connection_termination.enabled - Indicates whether the load balancer terminates connections at the end of the deregistration timeout. The value is true or false. The default is false.

Docs: https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_TargetGroupAttribute.html

Use Case

To customize the value for connection_termination attribute when defining NLB via CDK.

Proposed Solution

Expose a mechanism to set a value for connection_termination.enabled possibly via NetworkTargetGroupProps

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Avinm Avinm added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2021
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing label Oct 15, 2021
@njlynch
Copy link
Contributor

njlynch commented Oct 18, 2021

Thanks for the feature request.

In the interim, as a workaround, you can use escape hatches to set the attribute.

We welcome community contributions! If you are able, we encourage you to contribute.

@njlynch njlynch added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2021
@njlynch njlynch removed their assignment Oct 18, 2021
@yeti-g
Copy link

yeti-g commented Jan 19, 2022

The absence of this attribute causes a warning in the AWS console.

Screen Shot 2022-01-19 at 11 04 59 AM

@yeti-g
Copy link

yeti-g commented Jan 19, 2022

@njlynch please share an escape hatch example for a Fargate task's target group.

@michaeldrey michaeldrey mentioned this issue Jun 21, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #20821 Jul 6, 2022
mergify bot pushed a commit that referenced this issue Jul 6, 2022
@michaeldrey
feat(elbv2) expose connection_termination attribute on network target…
47bc9ee 
… group (#20821)

This adds `deregistration_delay.connection_termination.enabled` attribute to the `NetworkTargetGroupProps` as `connectionTermination`. This is [specific to Network Load balancers](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-targetgroupattribute.html).

I have added integration tests and unit tests.

closes #17010
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

iliapolo pushed a commit that referenced this issue Jul 6, 2022
@michaeldrey @iliapolo
feat(elbv2) expose connection_termination attribute on network target…
62191de 
… group (#20821)

This adds `deregistration_delay.connection_termination.enabled` attribute to the `NetworkTargetGroupProps` as `connectionTermination`. This is [specific to Network Load balancers](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-targetgroupattribute.html).

I have added integration tests and unit tests.

closes #17010
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa pushed a commit to daschaa/aws-cdk that referenced this issue Jul 9, 2022
@michaeldrey @daschaa
feat(elbv2) expose connection_termination attribute on network target…
4f44a4b 
… group (aws#20821)

This adds `deregistration_delay.connection_termination.enabled` attribute to the `NetworkTargetGroupProps` as `connectionTermination`. This is [specific to Network Load balancers](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-targetgroupattribute.html).

I have added integration tests and unit tests.

closes aws#17010
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elbv2) expose connection_termination attribute on network target group michaeldrey/aws-cdk
3 participants
@njlynch @Avinm @yeti-g