Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs-patterns): Add enableExecuteCommand configuration property ApplicationLoadBalancedFargateService #15769

Closed
2 tasks
rcollette opened this issue Jul 26, 2021 · 2 comments · Fixed by #18663
Assignees
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@rcollette
Copy link
Contributor

Surface the enableExecuteCommand property of a Fargate service as part of the ApplicationLoadBalancedFargateService construct.

Use Case

To enable debugging of services.

Other

Related to : #15768

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@rcollette rcollette added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 26, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Jul 26, 2021
@ryparker
Copy link
Contributor

ryparker commented Jul 27, 2021

Hey @rcollette 👋

Thanks for opening this request.

I'm going to mark this as p2 which means that we are unable to work on this immediately. We use +1s to help us prioritize our work, and as always we are happy to take contributions if anyone is interested to pick this up and submit a PR (please make sure to follow our contribution guidelines.)
🙏

Here's a workaround that can be used in the mean time:

const albFargateService = new ApplicationLoadBalancedFargateService(this, 'AlbFargateService', {
	...props
});

// Get the CloudFormation resource
const cfnFargateService = albFargateService.service.node;
cfnFargateService.addPropertyOverride('EnableExecuteCommand', true);

see docs on escape hatches for more info on this workaround.

@ryparker ryparker added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2021
@madeline-k madeline-k removed their assignment Aug 24, 2021
@mergify mergify bot closed this as completed in #18663 Jun 13, 2022
mergify bot pushed a commit that referenced this issue Jun 13, 2022
Fixes #15769, #15197
Supersedes #15497 by implementing the change for all patterns.
This PR implements support for ECS Exec in all ecs-patterns services.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

daschaa pushed a commit to daschaa/aws-cdk that referenced this issue Jul 9, 2022
Fixes aws#15769, aws#15197
Supersedes aws#15497 by implementing the change for all patterns.
This PR implements support for ECS Exec in all ecs-patterns services.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
5 participants