(aws-ecs): Provide an enableExecuteCommand method

[rcollette]

When the enableExecuteCommand property was added, the enableExecuteCommand() method was made private. The logic that handles this property should have also been exposed as a method so that this feature could be enabled subsequent to construction of the construct.

Use Case

For use cases where we do not have direct access to construction of the construct, such as in the case of ApplicationLoadBalancedFargateService.

Proposed Solution

Move all logic related handling of the enableExecuteCommand configuration property into the enableExecuteCommand() method and make that method public.

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[ryparker]

Thanks for creating this and separating it from the other linked issue #15769. 👍🏻

I'm curious to see what @madeline-k says, but for now I will relabel this as a bug and prioritize as p1 since you described that this was previously working as a public method and was changed to private in a recent update.

---

If anyone is visiting this issue and looking for a quick workaround please take a look at the docs on using escape hatches.

Example of using escape hatches on the ApplicationLoadBalancedFargateService:

const albFargateService = new ApplicationLoadBalancedFargateService(this, 'AlbFargateService', {
	...props
});

// Get the CloudFormation resource
const cfnFargateService = albFargateService.service.node;
cfnFargateService.addPropertyOverride('EnableExecuteCommand', true);

[rcollette]

@ryparker I apologize if I wasn't clear. The method I mentioned was never public. It was "made" in the first place private. So probably not as much a bug (not a breaking one at least)

[ryparker]

@ryparker I apologize if I wasn't clear. The method I mentioned was never public. It was "made" in the first place private. So probably not as much a bug (not a breaking one at least)

Gotcha thanks for clarifying. In that case i'll mark this as a p2 feature-request which means that we are unable to work on this immediately. We use +1s to help us prioritize our work, and as always we are happy to take contributions if anyone is interested to pick this up and submit a PR (please make sure to follow our contribution guidelines.)
🙏

[madeline-k]

@ryparker Agree with your triage here. And thanks for providing a workaround!

[LukvonStrom]

To quote from https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-exec.html: "You can't enable ECS Exec for existing tasks. It can only be enabled for new tasks.", so I don't see added benefit with this method

[hoegertn]

Yes, but calling a method on a construct still happens during synth before creating infrastructure. From a CFN perspective, there is no difference between settings props in a constructor or a method call.

[LukvonStrom]

@hoegertn are there any L2 constructs, that expose methods for props, that may be set during creation?

[hoegertn]

Depends on what you count as props. grantXX, addToXXPolicy, allowFrom/To and more I could look up.

[LukvonStrom]

@hoegertn these are side-effect causing methods, which have a legitimate purpose (imho), but I don't see that for this method here

[github-actions]

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[hoegertn]

Would love if this could happen