Update to Go 1.9 #1210
Merged
Update to Go 1.9 #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. waiting for test statuses to be updated before giving this a |
|
You need the 🚀 in your commit message, but otherwise LGTM after it passes! |
It's the latest revision, which includes microsoft/go-winio#48 |
yhlee-aws
force-pushed
the
go_1.9_upgrade
branch
from
a9425c8 to
6c1ec20
Compare
|
Updated PR with the updated 3rd party library files, my understanding of how go dep works was wrong; I thought the latest would be pulled down during build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating agent to go 1.9, see issues #681
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: N/A
Description for the changelog
Did not update changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: yes