Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.9 #681

Closed
samuelkarp opened this issue Jan 26, 2017 · 8 comments
Closed

Update to Go 1.9 #681

samuelkarp opened this issue Jan 26, 2017 · 8 comments
Assignees
@yhlee-aws
Labels
kind/enhancement pending release scope/ECS Agent
Milestone
1.17.0

Comments

@samuelkarp
Copy link
Contributor

Go 1.8 will be out soon and we should update.

The AWS SDK for Go will also need to be updated.
@samuelkarp
Copy link
Contributor Author

Go 1.8 is out.

@samuelkarp
Copy link
Contributor Author

We may need microsoft/go-winio#48.

@cabbruzzese
Copy link
Contributor

cabbruzzese commented Aug 22, 2017 •
edited
Loading

Confirmed microsoft/go-winio#41 when building in go 1.8. We should include microsoft/go-winio#48

@samuelkarp
Copy link
Contributor Author

Go 1.9 is out.

@samuelkarp samuelkarp changed the title Update to Go 1.8 Update to Go 1.9 Aug 24, 2017
@samuelkarp samuelkarp mentioned this issue Jan 10, 2018
Closed
8 tasks
@yhlee-aws yhlee-aws self-assigned this Jan 11, 2018
@yhlee-aws yhlee-aws mentioned this issue Jan 23, 2018
Merged
8 tasks
@yhlee-aws
Copy link
Contributor

is there something I need to do for using go-winio#48? (re: pr)

@samuelkarp
Copy link
Contributor Author

@yunhee-l You'll want to make sure our vendored version of go-winio has that commit. I'd probably just recommend updating it to the most recent version.

Same thing for the AWS SDK for Go.

@yhlee-aws
Copy link
Contributor

✗ dep status
PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED
...
github.com/Microsoft/go-winio * v0.4.7 7da180e 7da180e 1
...
github.com/aws/aws-sdk-go ^1.12.67 v1.12.67 decd990 decd990 33
...

Both are latest of their respective repo/branch.

@yhlee-aws yhlee-aws added this to the 1.17.0 milestone Jan 24, 2018
@sharanyad
Copy link
Contributor

This should be available as part of the new release v.1.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhlee-aws yhlee-aws

Labels
kind/enhancement pending release scope/ECS Agent
Projects
None yet
Milestone
1.17.0
Development

No branches or pull requests
5 participants
@cabbruzzese @samuelkarp @aaithal @sharanyad @yhlee-aws