Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml to fix boost linking error #144

Closed
wants to merge 2 commits into from
Closed

Update ci.yml to fix boost linking error #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76be53b
Update ci.yml to fix boost linking error
RogerZhongAWS Oct 31, 2023
79725e5
Merge branch 'main' into RogerZhongAWS-patch-4
RogerZhongAWS Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ jobs:
$env:Path += ";C:\Program Files (x86)\zlib\bin"
- name: Install boost
run: |
Invoke-WebRequest "https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.zip" -OutFile "boost_1_76_0.zip"
Expand-Archive "boost_1_76_0.zip" -Force
cd .\boost_1_76_0\boost_1_76_0\
Invoke-WebRequest "https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.zip" -OutFile "boost_1_81_0.zip"
Expand-Archive "boost_1_81_0.zip" -Force
cd .\boost_1_81_0\boost_1_81_0\
.\bootstrap.bat
.\b2 toolset=msvc-14.2 address-model=64 install define=BOOST_WINAPI_VERSION_WIN10 link=static
.\b2 toolset=msvc-14.2 address-model=64 install define=_WIN32_WINNT=0x0601 define=BOOST_WINAPI_VERSION_WIN7 link=static
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did we decide on this windows header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based off this thread: microsoft/vcpkg#22495

- name: Install protobuf
run: |
cd \
Expand All @@ -169,7 +169,7 @@ jobs:
run: |
mkdir build
cd build
cmake -DBUILD_TESTS=OFF -DBOOST_PKG_VERSION=1.76.0 -DWIN32_WINNT=0x0A00 -DBoost_USE_STATIC_LIBS=ON -DCMAKE_PREFIX_PATH="C:\Boost;C:\Program Files (x86)\Catch2;C:\Program Files (x86)\protobuf;C:\Program Files\OpenSSL" -G "Visual Studio 16 2019" -A x64 ..\
cmake -DBUILD_TESTS=OFF -DBOOST_PKG_VERSION=1.81.0 -DWIN32_WINNT=0x0601 -DBoost_USE_STATIC_LIBS=ON -DCMAKE_PREFIX_PATH="C:\Boost;C:\Program Files (x86)\Catch2;C:\Program Files (x86)\protobuf;C:\Program Files\OpenSSL" -G "Visual Studio 16 2019" -A x64 ..\
msbuild localproxy.vcxproj -p:Configuration=Release
- name: Upload Artifact
uses: actions/upload-artifact@v3
Expand Down
Loading