Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml to fix boost linking error #144

Closed
wants to merge 2 commits into from

Conversation

RogerZhongAWS
Copy link
Contributor

Motivation

Modifications

Change summary

Use windows 7 macros when building boost libraries

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

.\bootstrap.bat
.\b2 toolset=msvc-14.2 address-model=64 install define=BOOST_WINAPI_VERSION_WIN10 link=static
.\b2 toolset=msvc-14.2 address-model=64 install define=_WIN32_WINNT=0x0601 define=BOOST_WINAPI_VERSION_WIN7 link=static
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did we decide on this windows header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based off this thread: microsoft/vcpkg#22495

@HarshGandhi-AWS
Copy link
Contributor

The PR branch is out of date. Please merge the latest changes from main.

@RogerZhongAWS RogerZhongAWS force-pushed the RogerZhongAWS-patch-4 branch from 3a46b10 to 76be53b Compare January 8, 2024 23:45
@HarshGandhi-AWS HarshGandhi-AWS self-requested a review January 8, 2024 23:50
@RogerZhongAWS RogerZhongAWS deleted the RogerZhongAWS-patch-4 branch September 12, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants