Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): publish lib as a Lambda Layer #884
feat(build): publish lib as a Lambda Layer #884
Changes from 33 commits
dcf724d
18ed8c9
6c8939e
76fa1d8
e063843
5a884ee
bc0a318
b057127
583a12f
e12dc75
022c517
e24df14
0f50311
01b91a8
e286e8d
cdf4e1f
b03413e
e7a254d
44f0728
8401da8
fb99afc
297907e
2ebe192
5d8ad97
e70e5c1
f509c6a
a2d1be5
1e58383
f8fee27
810e0dc
d07ccf9
c8465e2
c2b0f1b
4a1c436
fa2f59b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this comment here because the file above called is a binary and doesn't allow comments:
Do we need this
layer-publisher/[email protected]
???There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now yes since my PR there is not merged yet : aws-samples/cdk-lambda-powertools-python-layer#52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks for the explanation