Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

feat: Generalize the construct to be usable by other PowerTools supported languages #52

Closed
wants to merge 1 commit into from

Conversation

flochaz
Copy link

@flochaz flochaz commented May 19, 2022

Lambda PowerTools for TypeScript is in a need to be able to build and deploy Lambda Layers for it's version of the library: aws-powertools/powertools-lambda-typescript#826

This PR generalize the construct to allow it to be reused by other runtimes and include the TypeScript version of it.

Next step would be to rename the construct package to be generic and not tailored to Python.

Tests

npm run test
...
----------------------------|---------|----------|---------|---------|-------------------
File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------------------------|---------|----------|---------|---------|-------------------
All files                   |   89.65 |    90.74 |     100 |   89.65 |                   
 index.ts                   |     100 |      100 |     100 |     100 |                   
 lambda-powertools-layer.ts |   89.28 |    90.74 |     100 |   89.28 | 63,109,120        
----------------------------|---------|----------|---------|---------|-------------------

Test Suites: 2 passed, 2 total
Tests:       20 passed, 20 total
Snapshots:   0 total
Time:        65.848 s, estimated 95 s
Ran all test suites.
👾 test » eslint | eslint --ext .ts,.tsx --fix --no-error-on-unmatched-pattern src test build-tools .projenrc.js

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

@github-actions github-actions bot closed this Jun 5, 2022
@am29d am29d reopened this Jun 13, 2022
@github-actions
Copy link

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

@github-actions github-actions bot closed this Jun 16, 2022
@am29d am29d reopened this Jul 21, 2022
@github-actions
Copy link

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

@github-actions github-actions bot closed this Jul 24, 2022
@flochaz
Copy link
Author

flochaz commented Aug 2, 2022

What's the plan here :) ?

@am29d
Copy link
Contributor

am29d commented Aug 3, 2022

Sorry for the delay Florian. I am on it and will rename the project to make it more general for both runtimes.

@am29d am29d reopened this Aug 3, 2022
@github-actions github-actions bot removed the stale label Aug 4, 2022
@github-actions
Copy link

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Aug 18, 2022
@github-actions
Copy link

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

@github-actions github-actions bot closed this Aug 21, 2022
@am29d am29d reopened this Aug 26, 2022
@am29d
Copy link
Contributor

am29d commented Aug 26, 2022

Conflict resolved manually and merged PR 998b162

@am29d am29d closed this Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants