Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(all): Fix docs and examples #472

Merged
merged 9 commits into from
Jan 19, 2022

Conversation

michaelbrewer
Copy link
Contributor

Description of your changes

Changes:

  • fix markdown lint errors
  • fix code examples to work
  • upgrade contributing guide to use npm ci
  • use simplified checks

How to verify this change

  • run local tests
  • open examples in webstorm for linting

Related issues, RFCs

  • NA

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes:
- fix markdown lint errors
- fix code examples to work
- upgrade contributing guide to use npm ci
- use simplified checks
@dreamorosi dreamorosi self-requested a review January 17, 2022 12:07
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 17, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 17, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR!

Below some notes:

Unrelated: in a next PR we could apply the same linting (i.e. single quotes, return types, etc.) also to the JSDoc strings in the utilities files (example).

@michaelbrewer
Copy link
Contributor Author

ok thanks @dreamorosi , i have responded to your question. The objective here was to main see if i can copy and paste the examples and see if they where valid or not.

flochaz
flochaz previously approved these changes Jan 18, 2022
@michaelbrewer
Copy link
Contributor Author

Oops there is merge conflicts. :-).

@michaelbrewer
Copy link
Contributor Author

@flochaz @dreamorosi - i have had to resolve conflicts and push and update to fix this.

flochaz
flochaz previously approved these changes Jan 18, 2022
@flochaz flochaz merged commit 524c268 into aws-powertools:main Jan 19, 2022
@michaelbrewer michaelbrewer deleted the fix-doc-examples branch January 19, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants