-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(all): Fix docs and examples #472
Conversation
Changes: - fix markdown lint errors - fix code examples to work - upgrade contributing guide to use npm ci - use simplified checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your PR!
Below some notes:
- The changes to the
examples/cdk/lib/*
have already been merged in fix: updated CDK examples to remove old references & improve comments #439 so I'd suggest you merge what's currently onmain
. - I'm okay with all proposed changes in
docs/core/logger.md
except the one in the sectionCustom Log formatter
, we are working on a PR (to be pushed/opened soon) to fix the issue highlighted in Bug: LogFormatter isn't exported from Logger module so users cannot use custom formatter feature #393 and export the class properly so that can be used in the example.
Unrelated: in a next PR we could apply the same linting (i.e. single quotes, return types, etc.) also to the JSDoc strings in the utilities files (example).
ok thanks @dreamorosi , i have responded to your question. The objective here was to main see if i can copy and paste the examples and see if they where valid or not. |
Oops there is merge conflicts. :-). |
@flochaz @dreamorosi - i have had to resolve conflicts and push and update to fix this. |
Description of your changes
Changes:
How to verify this change
Related issues, RFCs
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.