Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: LogFormatter isn't exported from Logger module so users cannot use custom formatter feature #393

Closed
ijemmy opened this issue Jan 3, 2022 · 1 comment · Fixed by #479
Closed

Bug: LogFormatter isn't exported from Logger module so users cannot use custom formatter feature #393

ijemmy opened this issue Jan 3, 2022 · 1 comment · Fixed by #479
Assignees
@dreamorosi
Labels
bug Something isn't working completed This item is complete and has been merged/shipped logger This item relates to the Logger Utility
Milestone
production-ready-...

Comments

@ijemmy
Copy link
Contributor

ijemmy commented Jan 3, 2022

Bug description

LogFormatter isn’t exported from Logger module so I can’t extend the class like in the doc.

image

Expected Behavior

I can import LogFormatter

Current Behavior

The class isn't exported

Possible Solution

  1. Import it from
  2. Ensure that all our tests import classes from package root

Steps to Reproduce

  1. Add `import {LogFormatter} from "@aws-lambda-powertools/logger"
  2. Yoru IDE will show syntax error.

Environment

  • Powertools version used: 0.2.0-beta.15
  • Packaging format (Layers, npm): npm
  • AWS Lambda function runtime: N/A
  • Debugging logs: N/A

Related issues, RFCs

N/A
@ijemmy ijemmy added bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Jan 3, 2022
@ijemmy ijemmy mentioned this issue Jan 3, 2022
Closed
23 tasks
@dreamorosi dreamorosi added this to the beta-release milestone Jan 3, 2022
@dreamorosi dreamorosi added logger This item relates to the Logger Utility and removed triage This item has not been triaged by a maintainer, please wait labels Jan 3, 2022
@dreamorosi dreamorosi self-assigned this Jan 17, 2022
@dreamorosi dreamorosi mentioned this issue Jan 17, 2022
Merged
9 tasks
@dreamorosi dreamorosi linked a pull request Jan 17, 2022 that will close this issue
fix(logger): correctly export LogFormatter #479
Merged
9 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi changed the title fix(logger): LogFormatter isn't exported from Logger module so users cannot use custom formatter feature Bug: LogFormatter isn't exported from Logger module so users cannot use custom formatter feature Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
bug Something isn't working completed This item is complete and has been merged/shipped logger This item relates to the Logger Utility
Projects
None yet
Milestone
production-ready-release
Development

Successfully merging a pull request may close this issue.

fix(logger): correctly export LogFormatter aws-powertools/powertools-lambda-typescript
3 participants
@ijemmy @dreamorosi @saragerion