-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(jmespath): 100% coverage and spec compliance #2271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
PRs with 1K+ LOC, largely documentation related
label
Mar 25, 2024
This was referenced Mar 25, 2024
sthulb
previously approved these changes
Mar 27, 2024
Quality Gate passedIssues Measures |
sthulb
approved these changes
Mar 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces the full test suite of the JMESPath utility.
The tests included in the PR reach 100% coverage as well as full compliance with the JMESPath specification. The latter point is achieved by adopting the official test suite, which according to the official website is a requisite for any library that wants to claims full compliance.
The test suite has been copied verbatim and adapted to the Jest test structure. The only meaningful change to the suite is the wording of the error messages thrown by the library, which have been adapted to fit the style of this project.
In addition to the compliance tests, found under the
packages/jmespath/test/unit/compliance
directory, I included also another catch-all test file that contains tests needed to reach 100% coverage of statements, lines, branches, and files.Related issues, RFCs
Issue number: #2270
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.