Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: standardized and consistent linting strategy across Lerna targets #1105

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

saragerion
Copy link
Contributor

@saragerion saragerion commented Sep 29, 2022

Description of your changes

This change formats a test file that was not correctly linted before: https://github.com/awslabs/aws-lambda-powertools-typescript/pull/1105/files#diff-5fa0a43152940e8ecf42dd84317e26ca2e7635efc102a6e869008c0ed47928e4R219

It also makes sure that all lerna packages get linted and linted with fix in the same way (using the same command).

Previously that was not the case. Before:

Screenshot 2022-09-29 at 16 03 32

How to verify this change

Related issues, RFCs

Issue number:

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@saragerion saragerion changed the title Fix/formatting deps Fix: standardized and consistent linting strategy across Lerna targets Sep 29, 2022
@saragerion saragerion marked this pull request as ready for review September 29, 2022 14:37
@dreamorosi
Copy link
Contributor

@saragerion Should we also change the husky/pre-push or husky/pre-commit here to use the -fix version?

@saragerion saragerion self-assigned this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants