Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: release pipeline fails due to command issue #1118

Closed
dreamorosi opened this issue Oct 17, 2022 · 2 comments · Fixed by #1119
Closed

Maintenance: release pipeline fails due to command issue #1118

dreamorosi opened this issue Oct 17, 2022 · 2 comments · Fixed by #1119
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Oct 17, 2022

Bug description

As part of the release process lerna calls the version command present in each one of the package.json files. This command runs a series of other lifecycle hooks like liniting the codebase. In #1105 we changed the name of the script from format to lint-fix in all the package.json files of the utilities.

However, in that PR, we forgot to update the content of the version command that still referenced the old name format.

This PR updates the content of the command from npm run format && git add -A src to npm run lint-fix && git add -A src (format becomes lint-fix).

Expected Behavior

Release process should run without errors.

Current Behavior

Release process throws an error because the format command is called by version but doesn't exist anymore.

Possible Solution

Change the content of the version command from npm run format && git add -A src to npm run lint-fix && git add -A src (format becomes lint-fix).

Steps to Reproduce

Make a release, check result of this attempt.

Environment

  • Powertools version used: N/A
  • Packaging format (Layers, npm): N/A
  • AWS Lambda function runtime: N/A
  • Debugging logs: N/A

Related issues, RFCs

#1105

@dreamorosi dreamorosi added bug Something isn't working internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Oct 17, 2022
@dreamorosi dreamorosi self-assigned this Oct 17, 2022
@dreamorosi dreamorosi linked a pull request Oct 17, 2022 that will close this issue
11 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Oct 17, 2022
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Oct 18, 2022
@dreamorosi
Copy link
Contributor Author

Released in v1.3.0

@dreamorosi dreamorosi added automation This item relates to automation and removed bug Something isn't working labels Nov 13, 2022
@dreamorosi dreamorosi changed the title Bug (all): release pipeline fails due to command issue Maintenance: release pipeline fails due to command issue Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant