Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): lint and type checking removal in Pydantic v2 quality check #3360

Merged
merged 5 commits into from
Nov 17, 2023
Merged

chore(ci): lint and type checking removal in Pydantic v2 quality check #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3ff186
Removing lint and type checking
leandrodamascena Nov 17, 2023
55ad2ad
Removing lint and type checking
leandrodamascena Nov 17, 2023
509a3c5
Adding file to test
leandrodamascena Nov 17, 2023
a800bcd
Adding file to test
leandrodamascena Nov 17, 2023
e6595db
Removing test
leandrodamascena Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/quality_check_pydanticv2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,5 @@ jobs:
run: poetry add "pydantic=^2.0.3"
- name: Install dependencies
run: make dev
- name: Formatting and Linting
run: make lint
- name: Static type checking
run: make mypy
- name: Test with pytest
run: make test
- name: Security baseline
run: make security-baseline
- name: Complexity baseline
run: make complexity-baseline
run: make test-pydanticv2
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ test:
poetry run pytest -m "not perf" --ignore tests/e2e --cov=aws_lambda_powertools --cov-report=xml
poetry run pytest --cache-clear tests/performance

test-pydanticv2:
poetry run pytest -m "not perf" --ignore tests/e2e
leandrodamascena marked this conversation as resolved.
Show resolved Hide resolved

unit-test:
poetry run pytest tests/unit

Expand Down