Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): lint and type checking removal in Pydantic v2 quality check #3360

Merged
merged 5 commits into from
Nov 17, 2023
Merged

chore(ci): lint and type checking removal in Pydantic v2 quality check #3360

merged 5 commits into from
Nov 17, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #3349

Summary

Changes

Removing lint and type check-ing steps

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner November 17, 2023 16:11
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Nov 17, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2023
@leandrodamascena leandrodamascena linked an issue Nov 17, 2023 that may be closed by this pull request
Maintenance: Run pydantic v2 workflow only for features using pydantic #3349
Closed
2 tasks
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Nov 17, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2023
rubenfonseca
rubenfonseca previously approved these changes Nov 17, 2023
View reviewed changes
heitorlessa
heitorlessa reviewed Nov 17, 2023
View reviewed changes
.github/workflows/quality_check_pydanticv2.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leandrodamascena leandrodamascena merged commit 364b8b4 into aws-powertools:develop Nov 17, 2023
5 checks passed
@leandrodamascena leandrodamascena deleted the action/pydanticv2 branch November 17, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

@rubenfonseca rubenfonseca rubenfonseca left review comments

Assignees
No one assigned
Labels
commons github-actions Pull requests that update Github_actions code internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: Run pydantic v2 workflow only for features using pydantic
3 participants
@leandrodamascena @rubenfonseca @heitorlessa