feat(tracer): support methods with the same name (ABCs) by including fully qualified name in v2 #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws-powertools#1455) Co-authored-by: Heitor Lessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
pull-request-size
bot
added
the
size/L
boring-cyborg
bot
added
the
dependencies
Codecov Report
@@ Coverage Diff @@
## v2 #1486 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 125 125
Lines 5602 5602
Branches 653 653
=======================================
Hits 5578 5578
Misses 12 12
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
heitorlessa
requested review from
heitorlessa
and removed request for
mploski
heitorlessa
reviewed
Sep 6, 2022
heitorlessa
reviewed
Sep 6, 2022
heitorlessa
reviewed
Sep 6, 2022
heitorlessa
reviewed
Sep 6, 2022
heitorlessa
reviewed
Sep 6, 2022
heitorlessa
suggested changes
Sep 6, 2022
boring-cyborg
bot
added
the
documentation
|
Looking... |
heitorlessa
approved these changes
Sep 8, 2022
heitorlessa
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
…fully qualified name in v2 (#1486) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
heitorlessa
added a commit
that referenced
this pull request
Sep 9, 2022
* develop: chore(deps-dev): bump aws-cdk-lib from 2.40.0 to 2.41.0 (#1507) update changelog with latest changes feat(tracer): support methods with the same name (ABCs) by including fully qualified name in v2 (#1486) chore(deps-dev): bump aws-cdk-aws-apigatewayv2-integrations-alpha from 2.39.1a0 to 2.40.0a0 (#1496) chore(deps-dev): bump mkdocs-material from 8.4.2 to 8.4.3 (#1504) chore(deps): bump pydantic from 1.10.1 to 1.10.2 (#1502) update changelog with latest changes feat(data-classes): add KafkaEvent and KafkaEventRecord (#1485) chore(deps-dev): bump pytest from 7.1.2 to 7.1.3 (#1497) update changelog with latest changes feat(event_handler): add cookies as 1st class citizen in v2 (#1487) chore(deps-dev): bump black from 22.6.0 to 22.8.0 (#1494) chore(deps-dev): bump aws-cdk-lib from 2.39.1 to 2.40.0 (#1495) chore(maintenance): add discord link to first PR and first issue (#1493) update changelog with latest changes refactor(batch): remove legacy sqs_batch_processor (#1492) chore(deps): bump pydantic from 1.10.0 to 1.10.1 (#1491) chore(deps-dev): bump flake8-variables-names from 0.0.4 to 0.0.5 (#1490)
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
…fully qualified name in v2 (aws-powertools#1486) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
…fully qualified name in v2 (aws-powertools#1486) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
rubenfonseca
added a commit
that referenced
this pull request
Sep 14, 2022
…fully qualified name in v2 (#1486) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
rubenfonseca
added a commit
that referenced
this pull request
Oct 14, 2022
…fully qualified name in v2 (#1486) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1454
Summary
Changes
This change modifies the name of the range generated by the capture_method tracker. In some cases it is very difficult to identify which functions are added in XRay just using the function name, the reason for this is because a python function/file/system can use abstract methods/classes or even functions with the same name in different classes.
User experience
Before to this change, the span name only used the function name:
After this change, the span name includes the module and Python qualified name (PEP 3155)
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.