Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Span operation names to include class name #1454

Closed
1 of 2 tasks
petarlishov opened this issue Aug 15, 2022 · 4 comments
Closed
1 of 2 tasks

Feature request: Span operation names to include class name #1454

petarlishov opened this issue Aug 15, 2022 · 4 comments
Assignees
Labels
breaking-change Breaking change feature-request feature request v2

Comments

@petarlishov
Copy link

Use case

Currently if you add a span to a function with the provided annotation tracer.capture_method, the created span only uses the function's name. So if it is a function within a class, say for example some implementation of an abstract class, it is hard to realise which particular method was called as there are multiple classes with the same method.

Solution/User Experience

If we include the class in the operation name of the span, I think that would be helpful. I am not really sure if I won't start doscussion on whether the full module name needs included as well, but I think in terms of usefulness, asking for the class name is a sensible middle ground that would cover most people's use cases (hopefully others don't often have the same class name within different modules of the same project)

Alternative solutions

No response

Acknowledgment

@petarlishov petarlishov added feature-request feature request triage Pending triage from maintainers labels Aug 15, 2022
@heitorlessa heitorlessa added the breaking-change Breaking change label Aug 18, 2022
@rubenfonseca
Copy link
Contributor

Hi @petarlishov thanks for opening this. We're actively trying to prioritize this issue for our v2 release in the next couple of weeks. We will also apply a similar fix to the idempotency utility. Stay tuned :)

@rubenfonseca rubenfonseca added area/tracer and removed triage Pending triage from maintainers labels Aug 19, 2022
@leandrodamascena
Copy link
Contributor

Hi @petarlishov, how are you? I'm working on it and fixing some issues in the tests before opening a PR. This feature will be included in v2 and it will take a few weeks for us to release this new version.

I was wondering if this feature is blocking something you need to work with, if so we can find a solution (as a feature flag) where you can set a custom name for the subsegment instead of getting this automatically.

Please let us know if you are comfortable waiting for v2 to be released or if an immediate solution would help your work further.

Thank you

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Sep 8, 2022
@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Sep 13, 2022
@aws-powertools aws-powertools deleted a comment from github-actions bot Sep 13, 2022
@heitorlessa heitorlessa added the v2 label Sep 20, 2022
@heitorlessa
Copy link
Contributor

Closing as we're wrap to launch V2

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking change feature-request feature request v2
Projects
None yet
Development

No branches or pull requests

4 participants