fix(logger): preserve std keys when using custom formatters #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owertools-python into develop * 'develop' of https://github.com/heitorlessa/aws-lambda-powertools-python: chore(governance): warn message on closed issues
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: docs(tracer): split and lint code snippets (aws-powertools#1260) fix(ci): quote prBody GH expr on_opened_pr
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: docs(tracer): snippets split, improved, and lint (aws-powertools#1261) fix(ci): merged_pr add issues write access
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(ci): disable merged_pr workflow
pull-request-size
bot
added
the
size/XS
pull-request-size
bot
removed
the
size/XS
pull-request-size
bot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## develop #1264 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5427 +4
Branches 618 619 +1
========================================
+ Hits 5417 5421 +4
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
7 tasks
heitorlessa
added a commit
that referenced
this pull request
Jul 4, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(logger): preserve std keys when using custom formatters (#1264)
heitorlessa
added a commit
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1263
Summary
Changes
This PR ensures all standard keys are included when using Custom Formatters.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.