-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tracer): split and lint code snippets #1260
Merged
heitorlessa
merged 8 commits into
aws-powertools:develop
from
heitorlessa:docs/tracer-code-split
Jun 23, 2022
Merged
docs(tracer): split and lint code snippets #1260
heitorlessa
merged 8 commits into
aws-powertools:develop
from
heitorlessa:docs/tracer-code-split
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owertools-python into develop * 'develop' of https://github.com/heitorlessa/aws-lambda-powertools-python: chore(governance): warn message on closed issues
boring-cyborg
bot
added
documentation
Improvements or additions to documentation
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
labels
Jun 23, 2022
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Jun 23, 2022
feedback received from @sthulb ==> Approach B. Tested with SAM and SAM CLI for parent folder ( |
heitorlessa
changed the title
docs(tracer): snippets split and linting
docs(tracer): split and lint code snippets
Jun 23, 2022
7 tasks
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Jun 23, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: docs(tracer): split and lint code snippets (aws-powertools#1260) fix(ci): quote prBody GH expr on_opened_pr
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Jun 23, 2022
* develop: chore: move to approach B for multiple IaC chore: add sam build gitignore docs(tracer): split and lint code snippets (aws-powertools#1260) fix(ci): quote prBody GH expr on_opened_pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1009
Summary
Changes
This PR splits code snippets into a top-level
examples
folder. Formatting and linting (make lint
) were adjusted to includeexamples
folder. We also introduce cfn-lint within pre-commit hooks to selectively lint changed infra files withinexamples
folder.The only downside is that documentation needs to be rebuilt/rerun when example files are changed, as live change won't reflect files that are included.
Convention
We'll keep all examples under
examples
folder. Each feature will have its own source code that match what's in the documentation, followed by one or more infrastructure as code customers could use in the future.Example for Tracer
Caveat
We need to ensure Lambda Powertools dependency/layer is used. In the case of Layers, we will need to upgrade the Layer version within
examples
as part of each release - @am29d your input is crucial here on the best way forward. Until Alex completes his Layer pipeline refactoring, we can build a workflow action to find/replace Layer ARN Version.Another caveat is that
cfn-lint
dropped support for 3.6. We're using an officialcfn-lint
GitHub Actions as a workaround.User experience
Example of adding an invalid SAM template for a code snippet
Code quality example using our set of rules
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/core/tracer.md