Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DateOnly and TimeOnly converters #503

Merged
merged 3 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

using System;
using System.Globalization;
using System.Text.Json;
using System.Text.Json.Serialization;

namespace AWS.Lambda.Powertools.Logging.Internal.Converters;

/// <summary>
/// DateOnly JSON converter
/// </summary>
public class DateOnlyConverter : JsonConverter<DateOnly>
{
private const string DateFormat = "yyyy-MM-dd";

/// <summary>
/// Converts DateOnly from JSON.
/// </summary>
/// <param name="reader"></param>
/// <param name="typeToConvert"></param>
/// <param name="options"></param>
/// <returns></returns>
public override DateOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
return DateOnly.ParseExact(reader.GetString()!, DateFormat, CultureInfo.InvariantCulture);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think if we need to read, you could also throw not implemented exception, but no harm to leave the logic.

}

/// <summary>
/// Converts DateOnly to JSON.
/// </summary>
/// <param name="writer"></param>
/// <param name="value"></param>
/// <param name="options"></param>
public override void Write(Utf8JsonWriter writer, DateOnly value, JsonSerializerOptions options)
{
writer.WriteStringValue(value.ToString(DateFormat, CultureInfo.InvariantCulture));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

using System;
using System.Globalization;
using System.Text.Json;
using System.Text.Json.Serialization;

namespace AWS.Lambda.Powertools.Logging.Internal.Converters;

/// <summary>
/// TimeOnly JSON converter
/// </summary>
internal class TimeOnlyConverter : JsonConverter<TimeOnly>
{
private const string TimeFormat = "HH:mm:ss.FFFFFFF";

/// <summary>
/// Converts TimeOnly from JSON.
/// </summary>
/// <param name="reader"></param>
/// <param name="typeToConvert"></param>
/// <param name="options"></param>
/// <returns></returns>
public override TimeOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
return TimeOnly.ParseExact(reader.GetString()!, TimeFormat, CultureInfo.InvariantCulture);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think if we need to read, you could also throw not implemented exception, but no harm to leave the logic.

}

/// <summary>
/// Converts TimeOnly to JSON.
/// </summary>
/// <param name="writer"></param>
/// <param name="value"></param>
/// <param name="options"></param>
public override void Write(Utf8JsonWriter writer, TimeOnly value, JsonSerializerOptions options)
{
writer.WriteStringValue(value.ToString(TimeFormat, CultureInfo.InvariantCulture));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,8 @@ private static JsonSerializerOptions BuildJsonSerializerOptions()
jsonOptions.Converters.Add(new ExceptionConverter());
jsonOptions.Converters.Add(new MemoryStreamConverter());
jsonOptions.Converters.Add(new ConstantClassConverter());
jsonOptions.Converters.Add(new DateOnlyConverter());
jsonOptions.Converters.Add(new TimeOnlyConverter());
return jsonOptions;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,8 @@ private JsonSerializerOptions BuildJsonSerializerOptions()
jsonOptions.Converters.Add(new ExceptionConverter());
jsonOptions.Converters.Add(new MemoryStreamConverter());
jsonOptions.Converters.Add(new ConstantClassConverter());
jsonOptions.Converters.Add(new DateOnlyConverter());
jsonOptions.Converters.Add(new TimeOnlyConverter());

jsonOptions.Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1219,5 +1219,87 @@ public void Log_Set_Execution_Environment_Context()
$"{Constants.FeatureContextIdentifier}/Logger/{assemblyVersion}");
env.Received(1).GetEnvironmentVariable("AWS_EXECUTION_ENV");
}

[Fact]
public void Log_Should_Serialize_DateOnly()
{
// Arrange
var loggerName = Guid.NewGuid().ToString();
var service = Guid.NewGuid().ToString();
var logLevel = LogLevel.Information;
var randomSampleRate = 0.5;

var configurations = Substitute.For<IPowertoolsConfigurations>();
configurations.Service.Returns(service);
configurations.LogLevel.Returns(logLevel.ToString());

var systemWrapper = Substitute.For<ISystemWrapper>();
systemWrapper.GetRandom().Returns(randomSampleRate);

var logger = new PowertoolsLogger(loggerName, configurations, systemWrapper, () =>
new LoggerConfiguration
{
Service = null,
MinimumLevel = null,
LoggerOutputCase = LoggerOutputCase.CamelCase
});

var message = new
{
PropOne = "Value 1",
PropTwo = "Value 2",
Date = new DateOnly(2022, 1, 1)
};

logger.LogInformation(message);

// Assert
systemWrapper.Received(1).LogLine(
Arg.Is<string>(s =>
s.Contains("\"message\":{\"propOne\":\"Value 1\",\"propTwo\":\"Value 2\",\"date\":\"2022-01-01\"}")
)
);
}

[Fact]
public void Log_Should_Serialize_TimeOnly()
{
// Arrange
var loggerName = Guid.NewGuid().ToString();
var service = Guid.NewGuid().ToString();
var logLevel = LogLevel.Information;
var randomSampleRate = 0.5;

var configurations = Substitute.For<IPowertoolsConfigurations>();
configurations.Service.Returns(service);
configurations.LogLevel.Returns(logLevel.ToString());

var systemWrapper = Substitute.For<ISystemWrapper>();
systemWrapper.GetRandom().Returns(randomSampleRate);

var logger = new PowertoolsLogger(loggerName, configurations, systemWrapper, () =>
new LoggerConfiguration
{
Service = null,
MinimumLevel = null,
LoggerOutputCase = LoggerOutputCase.CamelCase
});

var message = new
{
PropOne = "Value 1",
PropTwo = "Value 2",
Time = new TimeOnly(12, 0, 0)
};

logger.LogInformation(message);

// Assert
systemWrapper.Received(1).LogLine(
Arg.Is<string>(s =>
s.Contains("\"message\":{\"propOne\":\"Value 1\",\"propTwo\":\"Value 2\",\"time\":\"12:00:00\"}")
)
);
}
}
}
Loading