feat: Add DateOnly and TimeOnly converters #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
2 tasks
amirkaws
reviewed
Oct 12, 2023
libraries/src/AWS.Lambda.Powertools.Logging/Internal/LoggingAspectHandler.cs
Outdated
Show resolved
Hide resolved
libraries/src/AWS.Lambda.Powertools.Logging/Internal/LoggingAspectHandler.cs
Outdated
Show resolved
Hide resolved
libraries/src/AWS.Lambda.Powertools.Logging/Internal/LoggingAspectHandler.cs
Outdated
Show resolved
Hide resolved
| /// <returns></returns> | ||
| public override DateOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) | ||
| { | ||
| return DateOnly.ParseExact(reader.GetString()!, DateFormat, CultureInfo.InvariantCulture); |
There was a problem hiding this comment.
I don't think if we need to read, you could also throw not implemented exception, but no harm to leave the logic.
| /// <returns></returns> | ||
| public override TimeOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) | ||
| { | ||
| return TimeOnly.ParseExact(reader.GetString()!, TimeFormat, CultureInfo.InvariantCulture); |
There was a problem hiding this comment.
I don't think if we need to read, you could also throw not implemented exception, but no harm to leave the logic.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #501
Summary
.NET 6 is missing DateOnly and TimeOnly Json converters. This is causing issues serializing these two types.
Changes
Added two new converters for DateOnly and TimeOnly.
User experience
Logging will handle DateOnly fields without any additional or custom logic from application developers.
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.