Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop base module #255

Merged
merged 11 commits into from
Jan 19, 2024
Merged

chore: Drop base module #255

merged 11 commits into from
Jan 19, 2024

Conversation

bonclay7
Copy link
Member

@bonclay7 bonclay7 commented Jan 15, 2024 •
edited
Loading

What does this PR do?

We've been offering a "base" that acts like a glue between the modules. We realized this is not really necessary, brings complexity and could be simplified.

This PR removes the base module, implementation in examples and documentation.

To be merged after #252

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bonclay7 bonclay7 marked this pull request as draft January 15, 2024 18:15
@bonclay7 bonclay7 temporarily deployed to Observability Test January 15, 2024 20:15 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 15, 2024 21:22 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 15, 2024 21:38 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 15, 2024 22:14 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 15, 2024 23:11 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 16, 2024 00:19 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 16, 2024 01:04 — with GitHub Actions Inactive
@bonclay7 bonclay7 temporarily deployed to Observability Test January 18, 2024 15:44 — with GitHub Actions Inactive
@bonclay7 bonclay7 marked this pull request as ready for review January 18, 2024 16:01
@bonclay7 bonclay7 temporarily deployed to Observability Test January 19, 2024 16:20 — with GitHub Actions Inactive
@bonclay7 bonclay7 mentioned this pull request Jan 19, 2024
Merged
@bonclay7 bonclay7 requested a review from lewinkedrs January 19, 2024 18:02
lewinkedrs
lewinkedrs approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan and apply successfully tested. Looks good to me. Much cleaner than before.

@bonclay7 bonclay7 merged commit 7697ca9 into main Jan 19, 2024
36 checks passed
@bonclay7 bonclay7 deleted the drop/main-module branch January 19, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewinkedrs lewinkedrs lewinkedrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonclay7 @lewinkedrs