Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module to use the new container insights with CW for EKS #252

Merged
merged 52 commits into from
Jan 19, 2024

Conversation

ruchimo
Copy link
Contributor

@ruchimo ruchimo commented Jan 2, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

ruchimo and others added 30 commits August 9, 2023 13:40
@bonclay7 bonclay7 marked this pull request as ready for review January 8, 2024 22:26
@bonclay7 bonclay7 marked this pull request as draft January 8, 2024 22:26
Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to update the docs as well. Please see my comments

examples/eks-container-insights/README.md Outdated Show resolved Hide resolved
examples/eks-container-insights/README.md Outdated Show resolved Hide resolved
examples/eks-container-insights/main.tf Outdated Show resolved Hide resolved
modules/eks-container-insights/locals.tf Outdated Show resolved Hide resolved
Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes on documentation

docs/container-insights/eks.md Outdated Show resolved Hide resolved
docs/container-insights/eks.md Outdated Show resolved Hide resolved
docs/container-insights/eks.md Outdated Show resolved Hide resolved
docs/container-insights/eks.md Outdated Show resolved Hide resolved
docs/container-insights/eks.md Outdated Show resolved Hide resolved
examples/eks-container-insights/README.md Outdated Show resolved Hide resolved
examples/eks-container-insights/README.md Outdated Show resolved Hide resolved
examples/eks-container-insights/README.md Outdated Show resolved Hide resolved
@bonclay7 bonclay7 marked this pull request as ready for review January 17, 2024 18:08
@ruchimo
Copy link
Contributor Author

ruchimo commented Jan 18, 2024

@bonclay7 - updated with the recommendations and all checks have passed

@bonclay7 bonclay7 mentioned this pull request Jan 18, 2024
5 tasks
@bonclay7 bonclay7 changed the title [DRAFT] - Module to use the new container insights with CW for EKS Update module to use the new container insights with CW for EKS Jan 18, 2024
Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

examples/eks-container-insights/variables.tf Outdated Show resolved Hide resolved
modules/eks-container-insights/main.tf Show resolved Hide resolved
@ruchimo
Copy link
Contributor Author

ruchimo commented Jan 19, 2024

@bonclay7 - Incorporated your review comments

Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@bonclay7 bonclay7 merged commit 1f91205 into aws-observability:main Jan 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants