Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update grafana operator #249

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

rlanore
Copy link
Contributor

@rlanore rlanore commented Dec 19, 2023

What does this PR do?

Update grafana operator to 5.5.2 release.

Take care of i had to use main branch to aws-observability-accelerator repo since we haven't tag tu support this operator version. here

Motivation

Permit to use configMapRef into grafana dashboard manifest

see #246

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

@bonclay7
Copy link
Member

Thanks for the PR @rlanore, can we use this tag instead of main https://github.com/aws-observability/aws-observability-accelerator/releases/tag/v0.3.1

@bonclay7 bonclay7 self-requested a review December 19, 2023 20:04
Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's continue to use tags. I've released a new tag that include your changes https://github.com/aws-observability/aws-observability-accelerator/releases/tag/v0.3.1

@rlanore rlanore force-pushed the feat/upgrade-go branch 2 times, most recently from 6c00291 to 4e87598 Compare December 20, 2023 08:07
Update grafana operator
@rlanore
Copy link
Contributor Author

rlanore commented Dec 20, 2023

hi,
No problem i can change to still use tag.I pushed this change just now
Tested on my account every kustomization reconciliated

grafana-dashboards-adothealth                     True                 Applied revision: v0.3.1@sha1:b39123f0bd441015ff23bb342fdb63a6b51b0b2e
... ...

Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@bonclay7 bonclay7 merged commit 1f57056 into aws-observability:main Dec 20, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants