fix:url mandatory for datasource since opeator version > 5.4.0 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See linked issue @elamaran11. LGTM as current TF version uses release tags but wondering if there's any side effect to this? |
elamaran11
reviewed
Dec 14, 2023
There was a problem hiding this comment.
@bonclay7 Does this break for 5.4.0? We are yet to migrate to > 5.4.0 only with blueprints release friday?
|
@elamaran11 I think this should be good |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current datasource yaml we can't upgrade grafana operator to more recent version.
Description of changes:
Add 'url' to datasource yaml to be compliant with grafana-operator > 5.4.0
See: grafana/grafana-operator#1235
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.