feat: ADOT Container logs collection #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
reviewed
Jan 26, 2024
elamaran11
reviewed
Jan 29, 2024
There was a problem hiding this comment.
@arunvthangaraj This is very nice work, thankyou for doing this. Code changes, collector config all looks great, doc needs more work and screenshots needs to be new to OSS pattern.
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
elamaran11
changed the title
|
@arunvthangaraj Lets close the loose ends in documentation and try to get this PR to closure start of this week! |
elamaran11
requested changes
Feb 6, 2024
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
...new-eks-observability-accelerators/single-new-eks-container-logs-opensource-observability.md
Outdated
Show resolved
Hide resolved
1 task
|
/do-e2e-test single-new-eks-opensource-observability deploy |
|
/do-e2e-test single-new-eks-opensource-observability destroy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 134
Description of changes:
Enable container logs collection using ADOT
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.