-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make gitops-bridge example to use kubectl to deploy addons and workloads #1886
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,20 @@ that temporary file with the `kubectl` configuration. This approach offers the | |
advantage of not altering your existing `kubectl` context, allowing you to work | ||
in other terminal windows without interference. | ||
|
||
### Monitor GitOps Progress for Addons | ||
### Deploy ArgoCD Apps of ApplicationSets for Addons | ||
|
||
This command verifies the initial ArgoCD installation, ArgoCD will be re-configured when the addons are deployed and configured from git. | ||
```shell | ||
kubectl --context hub get all -n argocd | ||
``` | ||
This command creates the application set manifest to deploy the addons. | ||
```shell | ||
kubectl --context hub apply -n argocd -f ../hub/bootstrap/addons.yaml | ||
``` | ||
The application sets defined here will then deploy addons to any spoke clusters provisioned later using Terraform | ||
|
||
|
||
### Monitor GitOps Progress for Addons on Hub EKS Cluster | ||
|
||
Wait until all the ArgoCD applications' `HEALTH STATUS` is `Healthy`. | ||
Use `Ctrl+C` or `Cmd+C` to exit the `watch` command. ArgoCD Applications | ||
|
@@ -164,15 +177,22 @@ The output have a section `awsAuthConfig` with the `clusterName` and the `roleAR | |
|
||
### Verify the Addons on Spoke Clusters | ||
|
||
Verify that the addons are ready: | ||
The addons on the spoke clusters are deployed using the Application Sets created on the EKS Hub Cluster. Verify that the addons are ready: | ||
|
||
```shell | ||
for i in dev staging prod ; do echo $i && kubectl --context $i get deployment -n kube-system ; done | ||
``` | ||
|
||
### Deploy the sample application to EKS Spoke Clusters | ||
|
||
This command will deploy the application using kubectl to all clusters connected to the hub cluster, using the manifest files in [./hub/bootstrap/workloads.yaml](./hub/bootstrap/workloads.yaml). | ||
```shell | ||
kubectl --context hub apply -n argocd -f ../hub/bootstrap/workloads.yaml | ||
``` | ||
Comment on lines
+188
to
+191
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, apply with terraform |
||
|
||
### Monitor GitOps Progress for Workloads from Hub Cluster (run on Hub Cluster context) | ||
|
||
Watch until **all* the Workloads ArgoCD Applications are `Healthy` | ||
Watch until all the Workloads ArgoCD Applications are `Healthy` | ||
|
||
```shell | ||
kubectl --context hub get -n argocd applications -w | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to kubectl apply with Terraform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@candonov I don't understand the comment
In all our patterns now, we moved away from using terraform providers like kubernertes, helm, or kubectl and instead tell the user to use
kubectl apply
this way is easier to understand like we have in the single cluster gitops-bridge pattern here https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/patterns/gitops/getting-started-argocd#deploy-the-addons