feat: Make gitops-bridge example to use kubectl to deploy addons and workloads #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
|
@candonov please take a look when you have a chance. |
candonov
reviewed
Feb 25, 2024
Comment on lines
+68
to
+71
| This command creates the application set manifest to deploy the addons. | ||
| ```shell | ||
| kubectl --context hub apply -n argocd -f ../hub/bootstrap/addons.yaml | ||
| ``` |
There was a problem hiding this comment.
change to kubectl apply with Terraform
There was a problem hiding this comment.
@candonov I don't understand the comment
change to kubectl apply with Terraform
In all our patterns now, we moved away from using terraform providers like kubernertes, helm, or kubectl and instead tell the user to use kubectl apply this way is easier to understand like we have in the single cluster gitops-bridge pattern here https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/patterns/gitops/getting-started-argocd#deploy-the-addons
Comment on lines
+188
to
+191
| This command will deploy the application using kubectl to all clusters connected to the hub cluster, using the manifest files in [./hub/bootstrap/workloads.yaml](./hub/bootstrap/workloads.yaml). | ||
| ```shell | ||
| kubectl --context hub apply -n argocd -f ../hub/bootstrap/workloads.yaml | ||
| ``` |
There was a problem hiding this comment.
Same here, apply with terraform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes it more clear how the bootstrap of addons and workloads happens, by removing the use of gitops-bridge module to deploy the bootstrap ArgoCD apps.
This change should make it more clearn to the end user trying out the pattern and following step by step the instructions in the README.md of each corresponding gitops pattern.
Motivation and Context
How was this change tested?
pre-commit run -awith this PRAdditional Notes