Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for conditionally passing role wildcards to IRSA trust policy #19

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: Add support for conditionally passing role wildcards to IRSA trust policy #19

merged 1 commit into from
Aug 16, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add support for conditionally passing role wildcards to IRSA trust policy

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner August 15, 2023 14:45
rodrigobersa
rodrigobersa approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bryant!

@rodrigobersa rodrigobersa merged commit e039ac2 into main Aug 16, 2023
@rodrigobersa rodrigobersa deleted the feat/sso-wildcards branch August 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigobersa rodrigobersa rodrigobersa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add Condition variable
2 participants
@bryantbiggs @rodrigobersa