Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add Condition variable #15

Closed
Almenon opened this issue Jun 16, 2023 · 2 comments · Fixed by #19
Closed

Feature request: add Condition variable #15

Almenon opened this issue Jun 16, 2023 · 2 comments · Fixed by #19
Labels
enhancement New feature or request teams

Comments

@Almenon
Copy link

Almenon commented Jun 16, 2023

Using AWS IAM Identity Center is best practice according to AWS for assigning out permissions. However, it creates roles with unique names. To avoid having to hardcode unique names everywhere, AWS says you can use a condition with a wildcard in your trust policy. However, terraform-aws-eks-blueprints-teams does not support that currently.

If this repo added support that would make our code a lot cleaner and more maintainable, as we wouldn't have to have hardcoded AWS role names for each AWS account.

For reference see bottom of https://docs.aws.amazon.com/singlesignon/latest/userguide/referencingpermissionsets.html

@bryantbiggs
Copy link
Contributor

I think that sounds like a reasonable change - we'll add this to the list, thank you!

@Almenon
Copy link
Author

Almenon commented Aug 21, 2023

Thanks @bryantbiggs !

@bryantbiggs bryantbiggs moved this to Done in EKS Blueprints Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request teams
Projects
Status: Done
3 participants