Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Kinesis, CloudWatch Logs and Network Firewall Controllers #74

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

edgarsilva948
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@edgarsilva948 edgarsilva948 requested a review from a team as a code owner August 12, 2024 22:13
main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
just add to the description that it fixes #66 and #64

@edgarsilva948
Copy link
Contributor Author

This PR closes issues #66, #73, and #64.

@candonov candonov merged commit bfa0a53 into aws-ia:main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kinesis, CloudWatch Logs and Network Firewall controllers
2 participants