Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize IAM Policies to Use aws_iam_policy_document Format #66

Closed
edgarsilva948 opened this issue Aug 7, 2024 · 2 comments
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@edgarsilva948
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

To ensure consistency and maintainability, I suggest having all IAM policies within the module use the data "aws_iam_policy_document" format instead of directly embedding the JSON policy within the aws_iam_policy resource.

Describe the solution you would like

Adjust the policies from this to this format and then pass it to the source_policy_documents parameter like this.

Describe alternatives you have considered

N/A

Additional context

@candonov candonov added the good first issue Good for newcomers label Aug 7, 2024
@rogerlima95
Copy link

I would like to work on this issue

@candonov
Copy link
Contributor

Thank you @rogerlima95 , seems @edgarsilva948 already addressed it in this PR: #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants