fix: Avoid invalid-index when controllers disabled #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdellegrazie
force-pushed
the
fix/invalid-index
branch
from
6b4ac0f to
220e66a
Compare
bdellegrazie
changed the title
bdellegrazie
force-pushed
the
fix/invalid-index
branch
from
220e66a to
bcec04c
Compare
askulkarni2
requested changes
Jul 5, 2023
There was a problem hiding this comment.
Hi @bdellegrazie, thanks for reporting the issue and providing the PR!
When emrcontainers or step function capabilties were disabled, Terraform would try to assign the associated policy. The policy doesn't exist because that component is disabled. As a test, an all controllers disabled module has been added to the example. fixes: aws-ia#43
bdellegrazie
force-pushed
the
fix/invalid-index
branch
from
bcec04c to
9b84c2c
Compare
askulkarni2
reviewed
Jul 5, 2023
askulkarni2
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When emrcontainers or step function capabilties were disabled, Terraform would try to assign the associated policy. The policy doesn't exist because that component is disabled.
fixes: #43
What does this PR do?
avoids trying to reference the (non-existent) policy when the particular functionality (emr containers or step functions) is disabled
Motivation
At the moment, I only need the rds controller.
Invalid indexerror when emrcontainers or step functions (sfn) are not enabled #43Test Results
I have tested locally and it works without error now.
I have added a "fully disabled" module to the example which should test all controllers in their default disabled mode.
If this is problematic, happy for it to be removed.