Skip to content

Commit

Permalink
fix: Avoid invalid-index when controllers disabled
Browse files Browse the repository at this point in the history
When emrcontainers or step function capabilties were disabled, Terraform
would try to assign the associated policy. The policy doesn't exist
because that component is disabled.

As a test, an all controllers disabled module has been added to the example.

fixes: #43
  • Loading branch information
bdellegrazie committed Jul 5, 2023
1 parent 2bf218c commit 9b84c2c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ module "emrcontainers" {
role_permissions_boundary_arn = lookup(var.emrcontainers, "role_permissions_boundary_arn", null)
role_description = try(var.emrcontainers.role_description, "IRSA for emrcontainers controller for ACK")
role_policies = lookup(var.emrcontainers, "role_policies", {
AmazonEmrContainers = aws_iam_policy.emrcontainers[0].arn
AmazonEmrContainers = var.enable_emrcontainers ? aws_iam_policy.emrcontainers[0].arn : null
})
create_policy = try(var.emrcontainers.create_policy, false)

Expand Down Expand Up @@ -701,7 +701,7 @@ module "sfn" {
source = "aws-ia/eks-blueprints-addon/aws"
version = "1.1.0"

create = var.enable_emrcontainers
create = var.enable_sfn

# public.ecr.aws/aws-controllers-k8s/sfn_name-chart:1.0.2
name = try(var.sfn.name, local.sfn_name)
Expand Down Expand Up @@ -770,7 +770,7 @@ module "sfn" {
role_description = try(var.sfn.role_description, "IRSA for sfn controller for ACK")
role_policies = lookup(var.sfn, "role_policies", {
AWSStepFunctionsFullAccess = "${local.iam_role_policy_prefix}/AWSStepFunctionsFullAccess"
AWSStepFunctionsIamPassRole = aws_iam_policy.sfnpasspolicy[0].arn
AWSStepFunctionsIamPassRole = var.enable_sfn ? aws_iam_policy.sfnpasspolicy[0].arn : null
})
create_policy = try(var.sfn.create_policy, false)

Expand Down

0 comments on commit 9b84c2c

Please sign in to comment.