Expose Object Acl on upload and refactor local zone pattern #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-glenn
requested review from
aws-ia-ci,
jaymccon and
tonynv
as code owners
andrew-glenn
force-pushed
the
acl-on-upload
branch
4 times, most recently
from
955710b to
45c8a0c
Compare
tonynv
previously approved these changes
Jan 19, 2022
jaymccon
previously approved these changes
Jan 19, 2022
andrew-glenn
force-pushed
the
acl-on-upload
branch
from
45c8a0c to
051060e
Compare
tonynv
approved these changes
Jan 19, 2022
jaymccon
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR exposes
--object-aclCLI option (mapping tos3_object_aclin config) as well as refactors local zone determination for allowed pattern in json schema.